* [PATCH 0/3] Expose more controls from tegra-max98090
@ 2015-02-11 14:49 ` Tomeu Vizoso
0 siblings, 0 replies; 9+ messages in thread
From: Tomeu Vizoso @ 2015-02-11 14:49 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, Tomeu Vizoso, Alexandre Courbot,
alsa-devel, devicetree, Dylan Reid, Ian Campbell, Jaroslav Kysela,
Kumar Gala, Lars-Peter Clausen, Liam Girdwood, linux-tegra,
Mark Brown, Mark Rutland, Pawel Moll, Rob Herring, Stephen Warren,
Takashi Iwai, Thierry Reding, Wolfram Sang
Hello,
we need some more controls in userspace so policy can be applied at events
such as microphone and headphone jacks being plugged in, to be used by
Tegra-based Chromebooks.
Regards,
Tomeu
Tomeu Vizoso (3):
ASoC: tegra: Expose Headphones pin to userspace
ASoC: tegra: Add sink for the internal mic to tegra_max98090
ASoC: tegra: Add control for the Mic Jack pin
.../devicetree/bindings/sound/nvidia,tegra-audio-max98090.txt | 1 +
sound/soc/tegra/tegra_max98090.c | 4 ++++
2 files changed, 5 insertions(+)
--
1.9.3
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/3] ASoC: tegra: Expose Headphones pin to userspace
2015-02-11 14:49 ` Tomeu Vizoso
(?)
@ 2015-02-11 14:49 ` Tomeu Vizoso
-1 siblings, 0 replies; 9+ messages in thread
From: Tomeu Vizoso @ 2015-02-11 14:49 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, Tomeu Vizoso, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Stephen Warren, Thierry Reding,
Alexandre Courbot, Wolfram Sang, Dylan Reid, Lars-Peter Clausen,
alsa-devel, linux-tegra
So userspace can enable or disable it based on the current policy.
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
---
sound/soc/tegra/tegra_max98090.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/tegra/tegra_max98090.c b/sound/soc/tegra/tegra_max98090.c
index af3fb99..8df71a4 100644
--- a/sound/soc/tegra/tegra_max98090.c
+++ b/sound/soc/tegra/tegra_max98090.c
@@ -136,6 +136,7 @@ static const struct snd_soc_dapm_widget tegra_max98090_dapm_widgets[] = {
};
static const struct snd_kcontrol_new tegra_max98090_controls[] = {
+ SOC_DAPM_PIN_SWITCH("Headphones"),
SOC_DAPM_PIN_SWITCH("Speakers"),
};
--
1.9.3
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 2/3] ASoC: tegra: Add sink for the internal mic to tegra_max98090
2015-02-11 14:49 ` Tomeu Vizoso
(?)
(?)
@ 2015-02-11 14:49 ` Tomeu Vizoso
-1 siblings, 0 replies; 9+ messages in thread
From: Tomeu Vizoso @ 2015-02-11 14:49 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, Tomeu Vizoso, Rob Herring, Pawel Moll,
Mark Rutland, Ian Campbell, Kumar Gala, Stephen Warren,
Thierry Reding, Alexandre Courbot, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Dylan Reid, Lars-Peter Clausen,
Wolfram Sang, devicetree, linux-tegra, alsa-devel
Also adds a control for the pin of the internal mic, so userspace can
apply policy when the state of the external mic jack changes.
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
---
Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max98090.txt | 1 +
sound/soc/tegra/tegra_max98090.c | 2 ++
2 files changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max98090.txt b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max98090.txt
index c949abc..c3495be 100644
--- a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max98090.txt
+++ b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max98090.txt
@@ -18,6 +18,7 @@ Required properties:
* Headphones
* Speakers
* Mic Jack
+ * Int Mic
- nvidia,i2s-controller : The phandle of the Tegra I2S controller that's
connected to the CODEC.
diff --git a/sound/soc/tegra/tegra_max98090.c b/sound/soc/tegra/tegra_max98090.c
index 8df71a4..29ea87c 100644
--- a/sound/soc/tegra/tegra_max98090.c
+++ b/sound/soc/tegra/tegra_max98090.c
@@ -133,11 +133,13 @@ static const struct snd_soc_dapm_widget tegra_max98090_dapm_widgets[] = {
SND_SOC_DAPM_HP("Headphones", NULL),
SND_SOC_DAPM_SPK("Speakers", NULL),
SND_SOC_DAPM_MIC("Mic Jack", NULL),
+ SND_SOC_DAPM_MIC("Int Mic", NULL),
};
static const struct snd_kcontrol_new tegra_max98090_controls[] = {
SOC_DAPM_PIN_SWITCH("Headphones"),
SOC_DAPM_PIN_SWITCH("Speakers"),
+ SOC_DAPM_PIN_SWITCH("Int Mic"),
};
static int tegra_max98090_asoc_init(struct snd_soc_pcm_runtime *rtd)
--
1.9.3
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 3/3] ASoC: tegra: Add control for the Mic Jack pin
2015-02-11 14:49 ` Tomeu Vizoso
` (2 preceding siblings ...)
(?)
@ 2015-02-11 14:49 ` Tomeu Vizoso
-1 siblings, 0 replies; 9+ messages in thread
From: Tomeu Vizoso @ 2015-02-11 14:49 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, Tomeu Vizoso, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Stephen Warren, Thierry Reding,
Alexandre Courbot, Dylan Reid, Wolfram Sang, Lars-Peter Clausen,
alsa-devel, linux-tegra
So userspace can enable and disable the external microphone.
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
---
sound/soc/tegra/tegra_max98090.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/tegra/tegra_max98090.c b/sound/soc/tegra/tegra_max98090.c
index 29ea87c..1f20c2c 100644
--- a/sound/soc/tegra/tegra_max98090.c
+++ b/sound/soc/tegra/tegra_max98090.c
@@ -139,6 +139,7 @@ static const struct snd_soc_dapm_widget tegra_max98090_dapm_widgets[] = {
static const struct snd_kcontrol_new tegra_max98090_controls[] = {
SOC_DAPM_PIN_SWITCH("Headphones"),
SOC_DAPM_PIN_SWITCH("Speakers"),
+ SOC_DAPM_PIN_SWITCH("Mic Jack"),
SOC_DAPM_PIN_SWITCH("Int Mic"),
};
--
1.9.3
^ permalink raw reply related [flat|nested] 9+ messages in thread[parent not found: <1423666200-32365-1-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>]
* Re: [PATCH 0/3] Expose more controls from tegra-max98090
2015-02-11 14:49 ` Tomeu Vizoso
@ 2015-02-11 16:34 ` Stephen Warren
-1 siblings, 0 replies; 9+ messages in thread
From: Stephen Warren @ 2015-02-11 16:34 UTC (permalink / raw)
To: Tomeu Vizoso, linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: Javier Martinez Canillas, Alexandre Courbot,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw,
devicetree-u79uwXL29TY76Z2rM5mHXA, Dylan Reid, Ian Campbell,
Jaroslav Kysela, Kumar Gala, Lars-Peter Clausen, Liam Girdwood,
linux-tegra-u79uwXL29TY76Z2rM5mHXA, Mark Brown, Mark Rutland,
Pawel Moll, Rob Herring, Takashi Iwai, Thierry Reding,
Wolfram Sang
On 02/11/2015 07:49 AM, Tomeu Vizoso wrote:
> Hello,
>
> we need some more controls in userspace so policy can be applied at events
> such as microphone and headphone jacks being plugged in, to be used by
> Tegra-based Chromebooks.
The series,
Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/3] Expose more controls from tegra-max98090
@ 2015-02-11 16:34 ` Stephen Warren
0 siblings, 0 replies; 9+ messages in thread
From: Stephen Warren @ 2015-02-11 16:34 UTC (permalink / raw)
To: Tomeu Vizoso, linux-kernel
Cc: Javier Martinez Canillas, Alexandre Courbot, alsa-devel,
devicetree, Dylan Reid, Ian Campbell, Jaroslav Kysela, Kumar Gala,
Lars-Peter Clausen, Liam Girdwood, linux-tegra, Mark Brown,
Mark Rutland, Pawel Moll, Rob Herring, Takashi Iwai,
Thierry Reding, Wolfram Sang
On 02/11/2015 07:49 AM, Tomeu Vizoso wrote:
> Hello,
>
> we need some more controls in userspace so policy can be applied at events
> such as microphone and headphone jacks being plugged in, to be used by
> Tegra-based Chromebooks.
The series,
Acked-by: Stephen Warren <swarren@nvidia.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/3] Expose more controls from tegra-max98090
2015-02-11 14:49 ` Tomeu Vizoso
@ 2015-02-21 14:50 ` Mark Brown
-1 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2015-02-21 14:50 UTC (permalink / raw)
To: Tomeu Vizoso
Cc: Mark Rutland, Alexandre Courbot, alsa-devel, Lars-Peter Clausen,
Stephen Warren, Pawel Moll, devicetree, Takashi Iwai,
Liam Girdwood, Ian Campbell, linux-kernel, Rob Herring,
Thierry Reding, Wolfram Sang, Kumar Gala, linux-tegra, Dylan Reid,
Javier Martinez Canillas
[-- Attachment #1.1: Type: text/plain, Size: 563 bytes --]
On Wed, Feb 11, 2015 at 03:49:51PM +0100, Tomeu Vizoso wrote:
> Hello,
>
> we need some more controls in userspace so policy can be applied at events
> such as microphone and headphone jacks being plugged in, to be used by
> Tegra-based Chromebooks.
I see that your "v2" which only added an ack was sent less than a day
after this initial posting. Don't do that, it just adds to the mail
volume. Only resend if it's been a while and there's been no review or
if you've got an actual change to make otherwise the mail isn't really
adding anything.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/3] Expose more controls from tegra-max98090
@ 2015-02-21 14:50 ` Mark Brown
0 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2015-02-21 14:50 UTC (permalink / raw)
To: Tomeu Vizoso
Cc: linux-kernel, Javier Martinez Canillas, Alexandre Courbot,
alsa-devel, devicetree, Dylan Reid, Ian Campbell, Jaroslav Kysela,
Kumar Gala, Lars-Peter Clausen, Liam Girdwood, linux-tegra,
Mark Rutland, Pawel Moll, Rob Herring, Stephen Warren,
Takashi Iwai, Thierry Reding, Wolfram Sang
[-- Attachment #1: Type: text/plain, Size: 563 bytes --]
On Wed, Feb 11, 2015 at 03:49:51PM +0100, Tomeu Vizoso wrote:
> Hello,
>
> we need some more controls in userspace so policy can be applied at events
> such as microphone and headphone jacks being plugged in, to be used by
> Tegra-based Chromebooks.
I see that your "v2" which only added an ack was sent less than a day
after this initial posting. Don't do that, it just adds to the mail
volume. Only resend if it's been a while and there's been no review or
if you've got an actual change to make otherwise the mail isn't really
adding anything.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread