From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YLaPF-0002US-KT for mharc-qemu-trivial@gnu.org; Wed, 11 Feb 2015 11:44:53 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLaPD-0002RH-Aq for qemu-trivial@nongnu.org; Wed, 11 Feb 2015 11:44:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLaP8-0001L9-Hy for qemu-trivial@nongnu.org; Wed, 11 Feb 2015 11:44:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33362) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLaP8-0001Kw-Al; Wed, 11 Feb 2015 11:44:46 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1BGiiAf021093 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 11 Feb 2015 11:44:45 -0500 Received: from [10.36.112.44] (ovpn-112-44.ams2.redhat.com [10.36.112.44]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1BGidJL017254 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 11 Feb 2015 11:44:42 -0500 Message-ID: <54DB86F6.6060005@redhat.com> Date: Wed, 11 Feb 2015 17:44:38 +0100 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Gerd Hoffmann , qemu-devel@nongnu.org References: <1423673041-13522-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1423673041-13522-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: qemu-trivial@nongnu.org, Luiz Capitulino Subject: Re: [Qemu-trivial] [PATCH] spice: fix memory leak X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2015 16:44:52 -0000 On 11/02/2015 17:44, Gerd Hoffmann wrote: > Found by coverity. > > Signed-off-by: Gerd Hoffmann > --- > monitor.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/monitor.c b/monitor.c > index c3cc060..29d7e5b 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -1101,6 +1101,7 @@ static int client_migrate_info(Monitor *mon, const QDict *qdict, > if (strcmp(protocol, "spice") == 0) { > if (!qemu_using_spice(&err)) { > qerror_report_err(err); > + error_free(local_err); > return -1; > } > > Reviewed-by: Paolo Bonzini From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLaPH-0002XL-VN for qemu-devel@nongnu.org; Wed, 11 Feb 2015 11:44:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLaPE-0001NY-3n for qemu-devel@nongnu.org; Wed, 11 Feb 2015 11:44:55 -0500 Message-ID: <54DB86F6.6060005@redhat.com> Date: Wed, 11 Feb 2015 17:44:38 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1423673041-13522-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1423673041-13522-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] spice: fix memory leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Luiz Capitulino On 11/02/2015 17:44, Gerd Hoffmann wrote: > Found by coverity. > > Signed-off-by: Gerd Hoffmann > --- > monitor.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/monitor.c b/monitor.c > index c3cc060..29d7e5b 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -1101,6 +1101,7 @@ static int client_migrate_info(Monitor *mon, const QDict *qdict, > if (strcmp(protocol, "spice") == 0) { > if (!qemu_using_spice(&err)) { > qerror_report_err(err); > + error_free(local_err); > return -1; > } > > Reviewed-by: Paolo Bonzini