From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLaoE-0000Ea-Ad for qemu-devel@nongnu.org; Wed, 11 Feb 2015 12:10:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLao5-0001uF-J4 for qemu-devel@nongnu.org; Wed, 11 Feb 2015 12:10:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45267) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLao5-0001u3-4n for qemu-devel@nongnu.org; Wed, 11 Feb 2015 12:10:33 -0500 Message-ID: <54DB8D05.1030704@redhat.com> Date: Wed, 11 Feb 2015 10:10:29 -0700 From: Eric Blake MIME-Version: 1.0 References: <1423584999-13946-1-git-send-email-dgilbert@redhat.com> <1423584999-13946-3-git-send-email-dgilbert@redhat.com> <20150210164720.GK400@redhat.com> <54DA3880.2020705@redhat.com> <20150211164853.GF2371@work-vm> In-Reply-To: <20150211164853.GF2371@work-vm> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PPRQ8gfGHG8dqksUFM8jxWmsvUx4jRIkM" Subject: Re: [Qemu-devel] [PATCH 2/3] Add migrate -u option for -incoming pause List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: quintela@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org, amit.shah@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PPRQ8gfGHG8dqksUFM8jxWmsvUx4jRIkM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/11/2015 09:48 AM, Dr. David Alan Gilbert wrote: >> Agree, a new command for QMP would be better (it serves as both the ne= w >> command to use, and the witness that the '-incoming pause:' command li= ne >> works). The HMP 'migrate -u' is just fine, though (it's fine to have = a >> single HMP command smart enough to call out to two different QMP comma= nds). >=20 > I've split it out as you all suggested; I made it migrate-incoming and= > also made an HMP migrate_incoming; although as you say you can merge th= em, > I just find it easier when they match - if you're used to using an HMP > command it's easier when you need to find the matching QMP command. Fair enough; HMP exists for ease-of-use, so whichever way you found easier to code is sufficient :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --PPRQ8gfGHG8dqksUFM8jxWmsvUx4jRIkM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU240FAAoJEKeha0olJ0NqEzMH/032kbSy3hM26ADGvs7p59Lw LqRP0PtZbmEPyDaJJr4EbbLTPPvXL33A+BxopKlqL+LmoZXEFbnUJl1doKnmbuM6 FgrLCeNI6PBxiDOoUJIyS0sMrtGmcMEWeyzW7fjrWJQBa/EYu5C5J9hYEsm34Zs4 DgdYZpfc6Lmf5HXD0WNYoEc7rNPHYqXYyiS3+ecmyieZA19E/d8nmusB2vwVSl74 88UFZaAG6sRhSbj76x3v0FDU0XvjhUloiu7UK4MmIeIfBEBTckz8g6s4w24X1umS uVd/tMvA0M4lqSwsiWyAr3JHM6aR7Nhen0PvXC8EaTMSZGO1hW4Nc/P6K3va57c= =ulPD -----END PGP SIGNATURE----- --PPRQ8gfGHG8dqksUFM8jxWmsvUx4jRIkM--