From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753409AbbBKSXL (ORCPT ); Wed, 11 Feb 2015 13:23:11 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:63384 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752638AbbBKSXJ (ORCPT ); Wed, 11 Feb 2015 13:23:09 -0500 Message-ID: <54DB9E0A.7090009@fb.com> Date: Wed, 11 Feb 2015 11:23:06 -0700 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Christoph Hellwig CC: Subject: Re: [PATCH 1/2] block: handle the null_mapped flag correctly in blk_rq_map_user_iov References: <1423660070-24652-1-git-send-email-hch@lst.de> <1423660070-24652-2-git-send-email-hch@lst.de> In-Reply-To: <1423660070-24652-2-git-send-email-hch@lst.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.57.29] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.13.68,1.0.33,0.0.0000 definitions=2015-02-11_04:2015-02-11,2015-02-11,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1502110181 X-FB-Internal: deliver Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/11/2015 06:07 AM, Christoph Hellwig wrote: > The tape drivers (and the sg driver in a special case that doesn't matter > here) use the null_mapped flag to tell blk_rq_map_user to not copy around > any data into or out of the bounce buffers. blk_rq_map_user_iov never > got that treatment, which didn't matter until I refactored blk_rq_map_user > to be implemented in terms of blk_rq_map_user_iov. So this fixes a regression caused by: commit ddad8dd0a162fde61646a627a3017c258601dc8a Author: Christoph Hellwig Date: Sun Jan 18 16:16:29 2015 +0100 block: use blk_rq_map_user_iov to implement blk_rq_map_user Signed-off-by: Christoph Hellwig Reviewed-by: Ming Lei Signed-off-by: Jens Axboe which we should probably note in the commit. I'll add that. -- Jens Axboe