From: Peng Fan <B51431@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/3] imx:mx6slevk implement power init board
Date: Thu, 12 Feb 2015 09:38:59 +0800 [thread overview]
Message-ID: <54DC0433.9050703@freescale.com> (raw)
In-Reply-To: <CAOMZO5D6yJfgZu-_PbvyAMzkc2eHZ=GjgH=ozzd80tyNNss8YA@mail.gmail.com>
Hi, Fabio
On 2/11/2015 10:13 PM, Fabio Estevam wrote:
> On Wed, Feb 11, 2015 at 12:09 PM, Peng Fan <Peng.Fan@freescale.com> wrote:
>
>> +int power_init_board(void)
>> +{
>> + struct pmic *p;
>> + unsigned int ret;
>> +
>> + p = pfuze_common_init(I2C_PMIC);
>> + if (!p)
>> + return -ENODEV;
>> +
>> + ret = pfuze_mode_init(p, APS_PFM);
>> + if (ret < 0)
>> + return ret;
>> +
>> + return 0;
> What about doing 'return pfuze_mode_init(p, APS_PFM);' instead?
>
> Then you can get rid of the 'ret' variable and save some lines of code.
This is a good suggestion. I have fixed this and sent out a new v3 version.
>
> Thanks
Thanks
Peng.
prev parent reply other threads:[~2015-02-12 1:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 14:09 [U-Boot] [PATCH v2 0/3] imx: mx6slevk add pmic support Peng Fan
2015-02-11 14:09 ` [U-Boot] [PATCH v2 1/3] imx:mx6sl add I2C pad settings Peng Fan
2015-02-11 14:09 ` [U-Boot] [PATCH v2 2/3] imx:mx6slevk add pmic and i2c configuration Peng Fan
2015-02-11 14:09 ` [U-Boot] [PATCH v2 3/3] imx:mx6slevk implement power init board Peng Fan
2015-02-11 14:13 ` Fabio Estevam
2015-02-12 1:38 ` Peng Fan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DC0433.9050703@freescale.com \
--to=b51431@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.