From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLob4-0001OG-HA for qemu-devel@nongnu.org; Thu, 12 Feb 2015 02:54:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLob1-0002lI-6a for qemu-devel@nongnu.org; Thu, 12 Feb 2015 02:54:02 -0500 Received: from szxga01-in.huawei.com ([119.145.14.64]:64997) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLob0-0002jc-AO for qemu-devel@nongnu.org; Thu, 12 Feb 2015 02:53:59 -0500 Message-ID: <54DC5C02.2030702@huawei.com> Date: Thu, 12 Feb 2015 15:53:38 +0800 From: Gonglei MIME-Version: 1.0 References: <1423293616-10736-1-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1423293616-10736-1-git-send-email-arei.gonglei@huawei.com> Content-Type: text/plain; charset="gbk" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/4] bootdevcie: change the boot order validation logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "qemu-devel@nongnu.org" Cc: "armbru@redhat.com" , "dvaleev@suse.de" , "agraf@suse.de" , "Huangpeng (Peter)" On 2015/2/7 15:20, Gonglei (Arei) wrote: > From: Gonglei > > The reset logic can be done by both machine reset and > boot handler. So we shouldn't return error when the boot > handler callback don't be set in patch 1. > > Patch 2 check boot order argument validation > before vm running. > > Patch 3 passing &error_abort instead of NULL. > Patch 4 update boot order in MachineState in qemu_boot_set > in order to support changing boot order on other machine type, > such as sPAPR. > > v3 -> v2: > - rework patch 2 using clearer variable name and coding order. (Maruks) > - add patch 4 in this patch series because of relevance. > > v2 -> v1: > - add patch 2 suggested by Markus. > - rework patch 3. (Maruks) > - add R-by in patch 1. > > Dinar Valeev (1): > bootdevice: update boot_order in MachineState > > Gonglei (3): > bootdevice: remove the check about boot_set_handler > bootdevice: check boot order argument validation before vm running > bootdevice: add check in restore_boot_order() > > bootdevice.c | 16 ++++++++-------- > vl.c | 23 +++++++++++++++-------- > 2 files changed, 23 insertions(+), 16 deletions(-) > Any ideas, Markus? Thanks. With the Chinese new year during near, a seven day holiday has already on the way. So I plan to send a pull request on this Sunday. :) Regards, -Gonglei