From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Subject: Re: [PATCH] ASoC: omap-hdmi-audio: Add missing error check for devm_kzalloc Date: Thu, 12 Feb 2015 11:22:41 +0200 Message-ID: <54DC70E1.50300@ti.com> References: <1423732082-23815-1-git-send-email-kiran.padwal@smartplayin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [192.94.94.40]) by alsa0.perex.cz (Postfix) with ESMTP id 65FD52604D9 for ; Thu, 12 Feb 2015 10:22:48 +0100 (CET) In-Reply-To: <1423732082-23815-1-git-send-email-kiran.padwal@smartplayin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Kiran Padwal , Mark Brown Cc: alsa-devel@alsa-project.org, Takashi Iwai , linux-kernel@vger.kernel.org, Liam Girdwood , "Sarha, Jyri" , Kiran Padwal , linux-omap@vger.kernel.org, Jarkko Nikula List-Id: alsa-devel@alsa-project.org On 02/12/2015 11:08 AM, Kiran Padwal wrote: > This patch add a missing check on the return value of devm_kzalloc, > which would cause a NULL pointer dereference in a OOM situation. Acked-by: Peter Ujfalusi > = > Signed-off-by: Kiran Padwal > --- > sound/soc/omap/omap-hdmi-audio.c | 3 +++ > 1 file changed, 3 insertions(+) > = > diff --git a/sound/soc/omap/omap-hdmi-audio.c b/sound/soc/omap/omap-hdmi-= audio.c > index ccfb41c..f7eb42a 100644 > --- a/sound/soc/omap/omap-hdmi-audio.c > +++ b/sound/soc/omap/omap-hdmi-audio.c > @@ -352,6 +352,9 @@ static int omap_hdmi_audio_probe(struct platform_devi= ce *pdev) > return ret; > = > card =3D devm_kzalloc(dev, sizeof(*card), GFP_KERNEL); > + if (!card) > + return -ENOMEM; > + > card->name =3D devm_kasprintf(dev, GFP_KERNEL, > "HDMI %s", dev_name(ad->dssdev)); > card->owner =3D THIS_MODULE; > = -- = P=E9ter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932211AbbBLJXI (ORCPT ); Thu, 12 Feb 2015 04:23:08 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:34229 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754691AbbBLJXG (ORCPT ); Thu, 12 Feb 2015 04:23:06 -0500 Message-ID: <54DC70E1.50300@ti.com> Date: Thu, 12 Feb 2015 11:22:41 +0200 From: Peter Ujfalusi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Kiran Padwal , Mark Brown CC: Liam Girdwood , Jarkko Nikula , Jaroslav Kysela , Takashi Iwai , , , , Kiran Padwal , "Sarha, Jyri" Subject: Re: [PATCH] ASoC: omap-hdmi-audio: Add missing error check for devm_kzalloc References: <1423732082-23815-1-git-send-email-kiran.padwal@smartplayin.com> In-Reply-To: <1423732082-23815-1-git-send-email-kiran.padwal@smartplayin.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/12/2015 11:08 AM, Kiran Padwal wrote: > This patch add a missing check on the return value of devm_kzalloc, > which would cause a NULL pointer dereference in a OOM situation. Acked-by: Peter Ujfalusi > > Signed-off-by: Kiran Padwal > --- > sound/soc/omap/omap-hdmi-audio.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/sound/soc/omap/omap-hdmi-audio.c b/sound/soc/omap/omap-hdmi-audio.c > index ccfb41c..f7eb42a 100644 > --- a/sound/soc/omap/omap-hdmi-audio.c > +++ b/sound/soc/omap/omap-hdmi-audio.c > @@ -352,6 +352,9 @@ static int omap_hdmi_audio_probe(struct platform_device *pdev) > return ret; > > card = devm_kzalloc(dev, sizeof(*card), GFP_KERNEL); > + if (!card) > + return -ENOMEM; > + > card->name = devm_kasprintf(dev, GFP_KERNEL, > "HDMI %s", dev_name(ad->dssdev)); > card->owner = THIS_MODULE; > -- Péter