All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabien Chouteau <chouteau@adacore.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH 3/8] leon3: Replace unchecked qdev_init() by qdev_init_nofail()
Date: Thu, 12 Feb 2015 10:30:31 +0100	[thread overview]
Message-ID: <54DC72B7.5070001@adacore.com> (raw)
In-Reply-To: <1423071188-1085-4-git-send-email-armbru@redhat.com>

On 02/04/2015 06:33 PM, Markus Armbruster wrote:
> grlib_irqmp_create(), grlib_gptimer_create() and
> grlib_apbuart_create() are helpers to create and realize GRLIB
> devices.  Their only caller leon3_generic_hw_init() doesn't check for
> failure.  Only the first can actually fail, and only when the caller
> fails to set up a pointer property, which is a programming error.
> 
> Replace qdev_init() by qdev_init_nofail().
> 
> Cc: Fabien Chouteau <chouteau@adacore.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Fabien Chouteau <chouteau@adacore.com>

Thanks Markus,

  reply	other threads:[~2015-02-12  9:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-04 17:33 [Qemu-devel] [PATCH 0/8] Cleanups around unchecked qdev_init() Markus Armbruster
2015-02-04 17:33 ` [Qemu-devel] [PATCH 1/8] qdev: Improve qdev_init_nofail()'s error reporting Markus Armbruster
2015-02-04 17:33 ` [Qemu-devel] [PATCH 2/8] ide/isa: Replace unchecked qdev_init() by qdev_init_nofail() Markus Armbruster
2015-02-04 17:33 ` [Qemu-devel] [PATCH 3/8] leon3: " Markus Armbruster
2015-02-12  9:30   ` Fabien Chouteau [this message]
2015-02-04 17:33 ` [Qemu-devel] [PATCH 4/8] etsec: Replace " Markus Armbruster
2015-02-04 17:33 ` [Qemu-devel] [PATCH 5/8] serial: Factor out common serial_hds_isa_init() Markus Armbruster
2015-02-04 17:33 ` [Qemu-devel] [PATCH 6/8] serial: serial_hds_isa_init() shouldn't fail Markus Armbruster
2015-02-04 17:33 ` [Qemu-devel] [PATCH 7/8] parallel: Factor out common parallel_hds_isa_init() Markus Armbruster
2015-02-04 17:33 ` [Qemu-devel] [PATCH 8/8] parallel: parallel_hds_isa_init() shouldn't fail Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54DC72B7.5070001@adacore.com \
    --to=chouteau@adacore.com \
    --cc=afaerber@suse.de \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.