From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [RFC v1 1/8] xen: make dom0 specific changes depend
 on XEN_DOM0
Date: Thu, 12 Feb 2015 09:55:18 +0000
Message-ID: <54DC7886.7080802@citrix.com>
References: <1423720996-3332-1-git-send-email-mcgrof@do-not-panic.com>
	<1423720996-3332-2-git-send-email-mcgrof@do-not-panic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <david.vrabel@citrix.com>) id 1YLqUV-0002oF-RK
	for xen-devel@lists.xenproject.org; Thu, 12 Feb 2015 09:55:23 +0000
In-Reply-To: <1423720996-3332-2-git-send-email-mcgrof@do-not-panic.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>, xen-devel@lists.xenproject.org
Cc: jgross@suse.com, mcgrof@suse.com, david.vrabel@citrix.com, boris.ostrovsky@oracle.com
List-Id: xen-devel@lists.xenproject.org

On 12/02/15 06:03, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@suse.com>
> 
> These are Kconfig options which are known to only make
> sense with Xen dom0 support. This is as per the agreed
> upon changes to Xen's kconfig changes [0].
[...]
> --- a/arch/x86/xen/Kconfig
> +++ b/arch/x86/xen/Kconfig
> @@ -35,13 +35,13 @@ config XEN_MAX_DOMAIN_MEMORY
>  
>  config XEN_SAVE_RESTORE
>         bool
> -       depends on XEN
> +       depends on XEN_DOM0
>         select HIBERNATE_CALLBACKS
>         default y

This breaks save/restore of domUs.

>  config XEN_DEBUG_FS
>  	bool "Enable Xen debug and tuning parameters in debugfs"
> -	depends on XEN && DEBUG_FS
> +	depends on XEN_DOM0 && DEBUG_FS
>  	default n
>  	help
>  	  Enable statistics output and various tuning options in debugfs.

This is useful for domUs.

> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 08f41ad..34af197 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1409,7 +1409,7 @@ config WATCHDOG_RIO
>  
>  config XEN_WDT
>  	tristate "Xen Watchdog support"
> -	depends on XEN
> +	depends on XEN_DOM0
>  	help
>  	  Say Y here to support the hypervisor watchdog capability provided
>  	  by Xen 4.0 and newer.  The watchdog timeout period is normally one

Again, useful for domUs.

David