From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 74842E00945; Thu, 12 Feb 2015 03:23:28 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [74.125.82.48 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id A28A2E0093B for ; Thu, 12 Feb 2015 03:23:25 -0800 (PST) Received: by mail-wg0-f48.google.com with SMTP id l18so6288623wgh.7 for ; Thu, 12 Feb 2015 03:23:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=Qd2zRXMdOrLeJ5sJbU9BLooR1os83h7M5SieyEe2hr0=; b=UJz3ZY1PcktxdvbTWkyFkxys8k36y3wYiJXRZ/SKmnRZT65yW2AYWgpVsMAbZArq1O Yq1JenW22QvAUF3D9jbmoS7lv5ieT0oiKpxsRZvtI+mc3fUH7oJ+ksVxW41vK+tLbUMN xDGPy9E1o0QaqbdX1wSJcvZlmfG4t+mnwnfMH08Ya33qBdGzXy9MIccoNpENaoO9vZY0 7fYHYwOlxm1ruTt5H2vskUthgcw9qwuolldvtD5UcZDGVYFZ1p0t5fDGh6KBn4K6KbuW Tz+gDCwc4uDUl1pQ/lO+zQofZOpX+tDM6Knp3IERNbLcRtHV48jsexUf7EzT9Fxap1MM XYNA== X-Gm-Message-State: ALoCoQknKLe52+fS7BWVKV1V303Mp1FX2JF/9kEvoJzBw9yoyLx/bI+8cJQ+K2Jf2KcnVcMQ3s6l X-Received: by 10.180.218.229 with SMTP id pj5mr5063882wic.85.1423740204109; Thu, 12 Feb 2015 03:23:24 -0800 (PST) Received: from [192.168.2.171] ([83.217.123.106]) by mx.google.com with ESMTPSA id a1sm5241515wjs.40.2015.02.12.03.23.23 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Feb 2015 03:23:23 -0800 (PST) Message-ID: <54DC8D2B.5040004@intel.com> Date: Thu, 12 Feb 2015 11:23:23 +0000 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: "Barros Pena, Belen" , "toaster@yoctoproject.org" References: <1423586675-21515-1-git-send-email-michael.g.wood@intel.com> In-Reply-To: Subject: Re: [review-request][PATCH] bitbake: toaster: layerdetails Use new vcs reference api X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Feb 2015 11:23:28 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit On 11/02/15 12:20, Barros Pena, Belen wrote: > This works great, but could we generate the tooltip on hover only when the > revision is truncated? It's just a bit silly to show the tooltip when its > content shows exactly what you just hovered over. Sure please could you open a separate bug for that as it's not related to the vcs reference api patch > Thanks! > > Belén > > On 10/02/2015 16:44, "Michael Wood" wrote: > >> Use the new layer_version api so that we return the vcs reference whether >> that be the commit hash, brash name or the upstream branch to which the >> layer >> is associated with. >> >> [YOCTO #7192] >> >> Signed-off-by: Michael Wood >> --- >> bitbake/lib/toaster/toastergui/templates/layerdetails.html | 13 >> ++++++------- >> 1 file changed, 6 insertions(+), 7 deletions(-) >> >> diff --git a/bitbake/lib/toaster/toastergui/templates/layerdetails.html >> b/bitbake/lib/toaster/toastergui/templates/layerdetails.html >> index 4ffd071..79679c2 100644 >> --- a/bitbake/lib/toaster/toastergui/templates/layerdetails.html >> +++ b/bitbake/lib/toaster/toastergui/templates/layerdetails.html >> @@ -5,7 +5,7 @@ >> {% block localbreadcrumb %} >>
  • All layers
    • >>
  • >> - {{layerversion.layer.name}} ({{layerversion.commit|truncatechars:13}}) >> + {{layerversion.layer.name}} >> ({{layerversion.get_vcs_reference|truncatechars:13}}) >>
    • >> {% endblock %} >> {% block projectinfomain %} >> @@ -29,7 +29,7 @@ >> layerVersion : { >> name : "{{layerversion.layer.name}}", >> id : {{layerversion.id}}, >> - commit: "{{layerversion.commit}}", >> + commit: "{{layerversion.get_vcs_reference}}", >> inCurrentPrj : {{layer_in_project}}, >> url : "{% url 'layerdetails' layerversion.id %}", >> sourceId: {{layerversion.layer_source_id}}, >> @@ -66,7 +66,7 @@ >> {% include "layers_dep_modal.html" %} >>
    >>
    >> -

    {{layerversion.layer.name}} > data-toggle="tooltip" >> title="{{layerversion.commit}}">({{layerversion.commit|truncatechars:13}}) >>

    >> +

    {{layerversion.layer.name}} > data-toggle="tooltip" >> title="{{layerversion.get_vcs_reference}}">({{layerversion.get_vcs_referen >> ce|truncatechars:13}})

    >>
    >>
    >> >> @@ -144,10 +144,10 @@ >> >>
    Brach, tag or commit
    >>
    >> - > class="current-value">{{layerversion.commit}} >> + > class="current-value">{{layerversion.get_vcs_reference}} >>
    >>
    >> - >> + > value="{{layerversion.get_vcs_reference}}"> >> >> >>
    >> @@ -163,8 +163,7 @@ >> {% for ld in layerversion.dependencies.all %} >> >>
  • >> - >> - > title="{{ld.depends_on.layer.vcs_url}} | {{ld.depends_on.commit}}" >> href="{% url 'layerdetails' ld.depends_on.id >> %}">{{ld.depends_on.layer.name}} >> + > title="{{ld.depends_on.layer.vcs_url}} | >> {{ld.depends_on.get_vcs_reference}}" href="{% url 'layerdetails' >> ld.depends_on.id %}">{{ld.depends_on.layer.name}} >> > title="Delete"> >>
    • >>     >> -- >> 2.1.0 >> >> -- >> _______________________________________________ >> toaster mailing list >> toaster@yoctoproject.org >> https://lists.yoctoproject.org/listinfo/toaster