From: Nick Hoath <nicholas.hoath@intel.com>
To: "Lespiau, Damien" <damien.lespiau@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/2] drm/i915/skl: Fix always true comparison in a revision id check
Date: Thu, 12 Feb 2015 13:33:29 +0000 [thread overview]
Message-ID: <54DCABA9.1050908@intel.com> (raw)
In-Reply-To: <1423678904-23698-2-git-send-email-damien.lespiau@intel.com>
On 11/02/2015 18:21, Lespiau, Damien wrote:
> It's always a good idea to keep static analysis happy (also because it
> prompts doing the check like I proposed :), this time smatch complains:
>
> drivers/gpu/drm/i915/intel_ringbuffer.c:891 gen9_init_workarounds() warn:
> always true condition '((->dev->pdev->revision) >= (0)) => (0-255 >= 0)'
>
> That's because revision is a u8. Tweak a bit the condition then.
>
> Cc: Nick Hoath <nicholas.hoath@intel.com>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
A bit contrived :) but:
Reviewed-by: Nick Hoath <nicholas.hoath@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ringbuffer.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
> index 2060610..8735e56 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> @@ -957,8 +957,8 @@ static int gen9_init_workarounds(struct intel_engine_cs *ring)
> WA_SET_BIT_MASKED(HALF_SLICE_CHICKEN3,
> GEN9_DISABLE_OCL_OOB_SUPPRESS_LOGIC);
>
> - if (INTEL_REVID(dev) >= SKL_REVID_A0 &&
> - INTEL_REVID(dev) <= SKL_REVID_B0) {
> + if (INTEL_REVID(dev) == SKL_REVID_A0 ||
> + INTEL_REVID(dev) == SKL_REVID_B0) {
> /*
> * WaDisableDgMirrorFixInHalfSliceChicken5:skl
> * This is a pre-production w/a.
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-02-12 13:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 18:21 [PATCH 0/2] A couple of fixes on top of the recent W/A work Damien Lespiau
2015-02-11 18:21 ` [PATCH 1/2] drm/i915/skl: Fix always true comparison in a revision id check Damien Lespiau
2015-02-12 13:33 ` Nick Hoath [this message]
2015-02-11 18:21 ` [PATCH 2/2] drm/i915/skl: Use a LRI for WaDisableDgMirrorFixInHalfSliceChicken5 Damien Lespiau
2015-02-12 13:36 ` Nick Hoath
2015-02-13 8:59 ` Daniel Vetter
2015-02-13 7:03 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DCABA9.1050908@intel.com \
--to=nicholas.hoath@intel.com \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.