From: Rik van Riel <riel@redhat.com>
To: Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>
Cc: linux-mm@kvack.org, Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Rafael Aquini <aquini@redhat.com>
Subject: Re: [PATCH] mm: fix negative nr_isolated counts
Date: Thu, 12 Feb 2015 10:12:30 -0500 [thread overview]
Message-ID: <54DCC2DE.10503@redhat.com> (raw)
In-Reply-To: <54DC61C6.10502@suse.cz>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/12/2015 03:18 AM, Vlastimil Babka wrote:
> On 02/11/2015 10:09 PM, Andrew Morton wrote:
>>> Fixes: edc2ca612496 ("mm, compaction: move pageblock checks up
>>> from isolate_migratepages_range()") Signed-off-by: Hugh Dickins
>>> <hughd@google.com> Cc: stable@vger.kernel.org # v3.18+
>>
>> And why -stable? What user-visible problem is the bug causing?
>>
>
> Commit 35cd78156c "vmscan: throttle direct reclaim when too many
> pages are isolated already" by Rik seems to have introduced this
> congestion_wait() based on too_many_isolated(). The bug it was
> fixing:
>
> "When way too many processes go into direct reclaim, it is possible
> for all of the pages to be taken off the LRU. One result of this is
> that the next process in the page reclaim code thinks there are no
> reclaimable pages left and triggers an out of memory kill."
>
> So either this is now prevented by something else and
> too_many_isolated() could go away, or we should restore its
> functionality. Any idea, Rik?
I don't think that bug is prevented.
I have seen reports of OOM kills happening while the system
still has a lot of reclaimable page cache pages.
This might actually help explain that bug...
- --
All rights reversed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJU3MLdAAoJEM553pKExN6DheAH/RgOqPr/HwzgaalKd2JcQcSx
xuIL/AhjIf8SYIHO5TTr00lF6mMpXfLs6+7UzYlICYmJ+wA4jZ6MapfpqYH/nkYG
tCS/8kMvH+rfkrUMp8NDz1od4Akp9w153xpA/6rmNrGTrcwXY9L4R2ANj30sJ9bw
5aRvwsYKAbGjXwJqDFbkR6UySthEZ8wPlOZpjJyhBoA9kMx+hP/Aka+qjYkiS7Ny
DfMuEjaNl8dsFZuulc7olhKNSXLyQPNmZt+oQCfb82KH78r6qpH2mhIrRtTunY6z
9iLHrxRgN2j8ZtDPFVaxMWQ3CQlaBZgTigSx1p+MTYVq8nfUe2HhkBgs2EKuV18=
=hWac
-----END PGP SIGNATURE-----
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2015-02-12 15:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 7:06 [PATCH] mm: fix negative nr_isolated counts Hugh Dickins
2015-02-11 9:58 ` Vlastimil Babka
2015-02-12 7:10 ` Joonsoo Kim
2015-02-11 21:09 ` Andrew Morton
2015-02-12 8:18 ` Vlastimil Babka
2015-02-12 15:12 ` Rik van Riel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DCC2DE.10503@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.