From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: mitake.hitoshi@lab.ntt.co.jp, namei.unix@gmail.com,
kwolf@redhat.com, sheepdog@lists.wpkg.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] sheepdog: Fix misleading error messages in sd_snapshot_create()
Date: Thu, 12 Feb 2015 08:15:34 -0700 [thread overview]
Message-ID: <54DCC396.4030808@redhat.com> (raw)
In-Reply-To: <1423748990-9709-1-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 797 bytes --]
On 02/12/2015 06:49 AM, Markus Armbruster wrote:
> If do_sd_create() fails, it first reports the error returned, then
> reports a another one with strerror(errno). errno is meaningless at
> that point.
>
> Report just one error combining the valid information from both
> messages.
>
> Reported-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> Applies on top of my "[PATCH v2 00/10] Clean up around
> error_get_pretty(), qerror_report_err()", but rebasing to master would
> be trivial.
>
> block/sheepdog.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-02-12 15:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 13:49 [Qemu-devel] [PATCH] sheepdog: Fix misleading error messages in sd_snapshot_create() Markus Armbruster
2015-02-12 15:15 ` Eric Blake [this message]
2015-02-13 3:57 ` Liu Yuan
2015-02-27 12:56 ` Markus Armbruster
2015-03-04 13:03 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DCC396.4030808@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mitake.hitoshi@lab.ntt.co.jp \
--cc=namei.unix@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=sheepdog@lists.wpkg.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.