All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Hebden <james@hebden.net.au>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Add default configuration for Raspberry Pi 2 (ARMv7 & NEON)
Date: Fri, 13 Feb 2015 09:01:56 +1100	[thread overview]
Message-ID: <54DD22D4.3080601@hebden.net.au> (raw)
In-Reply-To: <20150212210330.GC4277@free.fr>



On 13/02/15 08:03, Yann E. MORIN wrote:
> Frank, All,
>
> On 2015-02-12 15:51 -0500, Frank Hunleth spake thusly:
>>>> +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="rpi-3.18.y-rebase"
>>>
>>> We can not use a branch name here. We want either a tag or a sha1.
>>> Currently, this is 0be82f722c097340632a59b879fbfee9c6148f53.
>>
>> Regarding the Raspberry Pi kernel version, what's the difference
>> between using the tip of the rpi-3.18.y branch and the tip of the
>> rpi-3.18.y-rebase branch? The kernel source code looks the same
>> between branches except for some trailing whitespace in files. Is the
>> rpi-3.18.y branch safe from rebases?
>
> No, the rpi-3.18.y is *not* safe from rebase; in fact, it is "constantly"
> rebased. That's a shame. :-(
>
> As for the rpi-3.18.y-rebase branch, I have absolutely no idea what it
> is meant for:
>    - is it a temporary branch that got pushed (it did not exist until a
>      few days ago)?
>    - is it the branch that will be rebased, leaving rpi-3.18.y alone?
>    - something else?
>
> So, I would prefer we stick to using the rpi-3.18.y (or even the
> rpi-3.19.y) branch, since we pretty much know how they handle it.
>
> /me should probably go and bug the RPi guys to put some tags on their
>      branches from time to time...
>
> Regards,
> Yann E. MORIN.
>

Thanks everyone for reviewing the patch and all of your helpful advice - 
much appreciated.

I'll resubmit the patch shortly, I'm just testing an image compiled with 
everyone's suggestions.

I've
  * Removed the custom kernel config, I'm now using bcm2709_defconfig.
  * Switched to the current tip of the rpi-2.19.y branch, using the 
commit ref instead of branch name. At the time I composed the patch I 
recall the rpi-3.18.y-rebase branch having a few more RPi2 related 
fixes, hence the choice. They seem identical now.
  * Cut down the size of the buildroot defconfig I've created. It's a 
proper defconfig now.
  * Switched to EABIhf. I recall testing this and not being able to get 
the image to boot, and meaning to switch it back on once I got the image 
booting. Good catch :)
  * Removed the rpi-firmware version change - I'll also be submitting a 
separate patch to bump the rpi-firmware package to the required level.

Sorry about the patch formatting - I had tried git send-email maybe a 
dozen times before resorting to using my mail reader to send the patch. 
Didn't noticed the wrapped lines until now - so I'll give git send-email 
another try.

Thanks,
James

  reply	other threads:[~2015-02-12 22:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-11  6:52 [Buildroot] [PATCH 1/1] Add default configuration for Raspberry Pi 2 (ARMv7 & NEON) James Hebden
2015-02-12 19:09 ` Yann E. MORIN
2015-02-12 19:56   ` Floris Bos
2015-02-12 20:18     ` Yann E. MORIN
2015-02-12 20:51   ` Frank Hunleth
2015-02-12 21:03     ` Yann E. MORIN
2015-02-12 22:01       ` James Hebden [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-02-11  6:45 James Hebden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54DD22D4.3080601@hebden.net.au \
    --to=james@hebden.net.au \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.