From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YM4nf-0003gL-Ni for qemu-devel@nongnu.org; Thu, 12 Feb 2015 20:12:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YM4nc-00031g-IS for qemu-devel@nongnu.org; Thu, 12 Feb 2015 20:12:07 -0500 Received: from cantor2.suse.de ([195.135.220.15]:39785 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YM4nc-00031X-CR for qemu-devel@nongnu.org; Thu, 12 Feb 2015 20:12:04 -0500 Message-ID: <54DD4F62.4070302@suse.de> Date: Fri, 13 Feb 2015 02:12:02 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1423767013-22935-1-git-send-email-lersek@redhat.com> In-Reply-To: <1423767013-22935-1-git-send-email-lersek@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] hw/arm/virt: "bus-range"/end is off by one List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek , peter.maydell@linaro.org, qemu-devel@nongnu.org On 12.02.15 19:50, Laszlo Ersek wrote: > According to "PCI Bus Binding to IEEE Std 1275-1994", 3.1.2. Bus-specific > Properties for Bus Nodes, the second integer in "bus-range" is an > inclusive limit. > > This seems to be consistent with several *.dtsi files in the kernel tree, > where examples like > > bus-range = <0 0>; > > are visible. > > In addition, the loop in gen_pci_parse_map_cfg_windows() > [drivers/pci/host/pci-host-generic.c] uses "bus_range->end" as an > inclusive limit. > > Signed-off-by: Laszlo Ersek Nice catch! Reviewed-by: Alexander Graf Alex