On 02/12/2015 10:10 PM, Andrew Cooper wrote:
On 12/02/15 06:54, Tian, Kevin wrote:


        

          

            
which presumably
means that the PML buffer flush needs to be aware of which gfns are
mapped by superpages to be able to correctly set a block of bits in the
logdirty bitmap.



          

          
Unfortunately PML itself can't tell us if the logged GPA comes from
superpage or not, but even in PML we still need to split superpages to
4K page, just like traditional write protection approach does. I think
this is because live migration should be based on 4K page granularity.
Marking all 512 bits of a 2M page to be dirty by a single write doesn't
make sense in both write protection and PML cases.



        

        
agree. extending one write to superpage enlarges dirty set unnecessary.
since spec doesn't say superpage logging is not supported, I'd think a
4k-aligned entry being logged if within superpage.


      

      
The spec states that an gfn is appended to the log strictly on the
transition of the D bit from 0 to 1.

In the case of a 2M superpage, there is a single D bit for the entire 2M
range.


The plausible (working) scenarios I can see are:

1) superpages are not supported (not indicated by the whitepaper).

    

    A better description would be -- PML doesn't check if it's
    superpage, it just operates with D-bit, no matter what page size.

    

      
2) a single entry will be written which must be taken to cover the
entire 2M range.
3) an individual entry is written for every access.

    

    Below is the reply from our hardware guy related to PML on
    superpage. It should have answered accurately.

    

    "As noted in Section 1.3, logging occurs whenever the CPU would set
    an EPT D bit.

    

    It does not matter whether the D bit is in an EPT PTE (4KB page),
    EPT PDE (2MB page), or EPT PDPTE (1GB page).

    

    In all cases, the GPA written to the PML log will be the address of
    the write that causes the D bit in question to be updated, with bits
    11:0 cleared.

    

    This means that, in the case in which the D bit is in an EPT PDE or
    an EPT PDPTE, the log entry will communicate which 4KB region within
    the larger page was being written.

    

    Once the D bit is set in one of these entries, a subsequent write to
    the larger page will not generate a log entry, even if that write is
    to a different 4KB region within the larger page.  This is because
    log entries are created only when a D bit is being set and a write
    will not cause a D bit to be set if the page's D bit is already set.

    

    The log entries do not communicate the level of the EPT
    paging-structure entry in which the D bit was set (i.e., it does not
    communicate the page size). "

    

    Thanks,

    -Kai

    

                                

                              
    

      

Have I missed anything?

~Andrew


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel