On 02/12/2015 05:48 AM, Jukka Rissanen wrote:
> Test the dbus disconnect watch support.
> ---
>   Makefile.am            |   3 +
>   unit/test-dbus-watch.c | 388 +++++++++++++++++++++++++++++++++++++++++++++++++
>   2 files changed, 391 insertions(+)
>   create mode 100644 unit/test-dbus-watch.c
>

That seems like an awful lot of copy-paste. Can we isolate the actual 
signal dispatcher and unit test it properly?  For example, you can 
always make the message_filter function private (e.g. without 
LIB_EXPORT) instead of static and feed it signals created using e.g. 
l_dbus_message_new_signal or dbus_message_from_blob

Alternatively, fold this into test-dbus.c if possible.

Regards,
-Denis