From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YM7yS-0003bH-0G for qemu-devel@nongnu.org; Thu, 12 Feb 2015 23:35:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YM7yO-0003C2-NL for qemu-devel@nongnu.org; Thu, 12 Feb 2015 23:35:27 -0500 Received: from mail113-250.mail.alibaba.com ([205.204.113.250]:54650 helo=us-alimail-mta1.hst.scl.en.alidc.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YM7yO-0003By-DD for qemu-devel@nongnu.org; Thu, 12 Feb 2015 23:35:24 -0500 Message-ID: <54DD80D7.1020500@sunrus.com.cn> Date: Fri, 13 Feb 2015 12:43:03 +0800 From: Chen Gang S MIME-Version: 1.0 References: <54DBED38.4060005@sunrus.com.cn> <54DBEFD3.1070609@sunrus.com.cn> <54DBF2D2.3000802@ezchip.com> <54DC1EC7.9000808@sunrus.com.cn> <54DD29BA.4040003@ezchip.com> In-Reply-To: <54DD29BA.4040003@ezchip.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chris Metcalf , riku.voipio@iki.fi, Peter Maydell Cc: "walt@tilera.com" , qemu-devel On 2/13/15 06:31, Chris Metcalf wrote: > On 2/11/2015 10:32 PM, Chen Gang S wrote: >> And excuse me, my English is not quite well, I don't quite understand: >> >> "fixing anything that breaks as a result". >> >> Could you provide more details? Thanks. > > So if you undefine TARGET_NR_open, etc, hopefully qemu will build. If it does not build, you should probably find out why, and fix it. Perhaps you can use NR_openat as a replacement for NR_open, etc. > Originally, I have tried to remove TARGET_NR_open and others, they can not pass building, and I also noticed about NR_openat. But at last, I still remain TARGET_NR_open and others (with related comments): - Another platforms (e.g. microblaze, arm64) defined them, too. - It is only for linux-user, can bypass Linux tile kernel. So it is still correct. - It really wastes memory and storage a little, but for me, the related maintainers (not me) need to consider about whether let the code more complex or save memory a little. >> Welcome the related diffs, I guess, it must be helpful. :-) > > I uploaded it to: > > http://173.201.26.195/scm/qemu-kvm-0.13.0.get > > Notice that this is against a much older version of qemu, though. > OK, thanks. After read through, it is useful to me. :-) Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed