From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51388) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YM9d4-0003j4-U2 for qemu-devel@nongnu.org; Fri, 13 Feb 2015 01:21:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YM9d1-0006Jr-Km for qemu-devel@nongnu.org; Fri, 13 Feb 2015 01:21:30 -0500 Received: from mail-qg0-x230.google.com ([2607:f8b0:400d:c04::230]:54008) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YM9d1-0006Jm-Fj for qemu-devel@nongnu.org; Fri, 13 Feb 2015 01:21:27 -0500 Received: by mail-qg0-f48.google.com with SMTP id a108so11801815qge.7 for ; Thu, 12 Feb 2015 22:21:27 -0800 (PST) Sender: Richard Henderson Message-ID: <54DD97E3.8090905@twiddle.net> Date: Thu, 12 Feb 2015 22:21:23 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1423231328-15662-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1423231328-15662-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] bitops.h: sextract64() return type should be int64_t, not uint64_t List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: patches@linaro.org On 02/06/2015 06:02 AM, Peter Maydell wrote: > The documentation for sextract64() claims that the return type is > an int64_t, but the code itself disagrees. Fix the return type to > conform to the documentation and to bring it into line with > sextract32(), which returns int32_t. > > Signed-off-by: Peter Maydell > --- > I quickly eyeballed all the callers and I don't think any of them > were relying on the unsignedness of the return type. > --- > include/qemu/bitops.h | 2 +- Reviewed-by: Richard Henderson Via trivial? r~