From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YM9if-0006rW-9j for qemu-devel@nongnu.org; Fri, 13 Feb 2015 01:27:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YM9ic-0008MI-3k for qemu-devel@nongnu.org; Fri, 13 Feb 2015 01:27:17 -0500 Received: from out1134-201.mail.aliyun.com ([42.120.134.201]:11991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YM9ib-0008JJ-FY for qemu-devel@nongnu.org; Fri, 13 Feb 2015 01:27:14 -0500 Message-ID: <54DD9B0D.8020102@sunrus.com.cn> Date: Fri, 13 Feb 2015 14:34:53 +0800 From: Chen Gang S MIME-Version: 1.0 References: <54DBED38.4060005@sunrus.com.cn> <54DBEFD3.1070609@sunrus.com.cn> <54DBF2D2.3000802@ezchip.com> <54DC1EC7.9000808@sunrus.com.cn> <54DD29BA.4040003@ezchip.com> <54DD80D7.1020500@sunrus.com.cn> <54DD8F2F.2090703@sunrus.com.cn> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: "walt@tilera.com" , Chris Metcalf , Riku Voipio , qemu-devel On 2/13/15 13:43, Peter Maydell wrote: > On 13 February 2015 at 05:44, Chen Gang S wrote: >> Which issue of correctness will occur? I can not enum it. > > If the Linux kernel does not implement these syscalls then > QEMU must not either. Attempting them should fail, same as > if you attempted them with the real kernel. > >> - linux-user already bypasses target linux kernel, and libc for tilegx >> can not generate these calls (not defined for libc, either). > > Just because libc doesn't try to do these things doesn't mean > QEMU should do the wrong thing for them. > >> - For any informal using, linux-user can still operate NR_open and >> others, it is harmless. > > But it is still wrong. > OK, I shall send patch v3 for it, after all related patches are reviewed. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed