From: tolga ceylan <tolga.ceylan@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Lidza Louina <lidza.louina@gmail.com>,
Mark Hounschell <markh@compro.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Staging: dgnc: dgnc_tty: code style improvements
Date: Thu, 12 Feb 2015 23:18:50 -0800 [thread overview]
Message-ID: <54DDA55A.9090600@gmail.com> (raw)
In-Reply-To: <1423808441.2795.1.camel@perches.com>
On 02/12/2015 10:20 PM, Joe Perches wrote:
> On Thu, 2015-02-12 at 21:58 -0800, Tolga Ceylan wrote:
>> On Wed, Feb 11, 2015 at 2:36 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>>> That looks kind of uglier than before. Please run your patch throught
>>> scripts/checkpatch.pl --strict.
> []
>> Running with --strict helped, but now I'm also getting warnings for
>> camel case usage.
>
> You can use --strict --ignore=camelcase
>
>> If I try to fix camel case, then
>> the patch will get much larger spanning many dgnc_* files. I can
>> proceed with this if you think it is valuable/acceptable.
>
> I suggest not.
>
>
Just noticed this warning in all dgnc_* files:
* NOTE TO LINUX KERNEL HACKERS: DO NOT REFORMAT THIS CODE!
*
* This is shared code between Digi's CVS archive and the
* Linux Kernel sources.
* Changing the source just for reformatting needlessly breaks
* our CVS diff history.
*
* Send any bug fixes/changes to: Eng.Linux at digi dot com.
* Thank you.
Seems unusual. Also get_maintainers.pl does not return any digi dot com addresses.
next prev parent reply other threads:[~2015-02-13 7:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 9:08 [PATCH 1/1] Staging: dgnc: dgnc_tty: code style improvements Tolga Ceylan
2015-02-11 10:36 ` Dan Carpenter
2015-02-13 5:58 ` Tolga Ceylan
2015-02-13 6:20 ` Joe Perches
2015-02-13 7:18 ` tolga ceylan [this message]
2015-02-13 7:37 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DDA55A.9090600@gmail.com \
--to=tolga.ceylan@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.