From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Stephen Boyd <sboyd@codeaurora.org>,
Mike Turquette <mturquette@linaro.org>
Cc: "Tomeu Vizoso" <tomeu.vizoso@collabora.com>,
"Emilio López" <emilio@elopez.com.ar>,
"Peter De Schrijver" <pdeschrijver@nvidia.com>,
"Robert Jarzmik" <robert.jarzmik@free.fr>,
"Giuseppe Cavallaro" <peppe.cavallaro@st.com>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] clk: Replace explicit clk assignment with __clk_hw_set_clk
Date: Fri, 13 Feb 2015 08:23:03 +0100 [thread overview]
Message-ID: <54DDA657.7030407@collabora.co.uk> (raw)
In-Reply-To: <54DD051D.8020701@codeaurora.org>
Hello Stephen,
On 02/12/2015 08:55 PM, Stephen Boyd wrote:
> On 02/12/15 05:58, Javier Martinez Canillas wrote:
>>
>> The changes were made using the following cocinelle semantic patch:
>>
>> @i@
>> @@
>>
>> @depends on i@
>> identifier dst;
>> @@
>>
>> - dst->clk = hw->clk;
>> + __clk_hw_set_clk(dst, hw);
>>
>> @depends on i@
>> identifier dst;
>> @@
>>
>> - dst->hw.clk = hw->clk;
>> + __clk_hw_set_clk(&dst->hw, hw);
>>
>> Fixes: 035a61c314eb3 ("clk: Make clk API return per-user struct clk instances")
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>
> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
>
Thanks a lot for your review.
> Did you run this on all files that include clk-provider.h? I hope there
> aren't similar situations in arch/arm/ for example.
>
Yes, I did run spatch against all the files that include clk-provider.h
but only were matches in the drivers/clk files changed by $subject.
Best regards,
Javier
prev parent reply other threads:[~2015-02-13 7:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 13:58 [PATCH v2 0/3] clk: Some fixes for the per-user clk API changes Javier Martinez Canillas
2015-02-12 13:58 ` [PATCH v2 1/3] clk: Don't dereference parent clock if is NULL Javier Martinez Canillas
2015-02-12 19:00 ` Stephen Boyd
2015-02-12 13:58 ` [PATCH v2 2/3] clk: Add __clk_hw_set_clk helper function Javier Martinez Canillas
2015-02-12 19:55 ` Stephen Boyd
2015-02-13 7:28 ` Javier Martinez Canillas
2015-02-12 13:58 ` [PATCH v2 3/3] clk: Replace explicit clk assignment with __clk_hw_set_clk Javier Martinez Canillas
2015-02-12 16:12 ` Robert Jarzmik
2015-02-12 19:55 ` Stephen Boyd
2015-02-13 7:23 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DDA657.7030407@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=emilio@elopez.com.ar \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=pdeschrijver@nvidia.com \
--cc=peppe.cavallaro@st.com \
--cc=robert.jarzmik@free.fr \
--cc=sboyd@codeaurora.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.