From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMCZL-0000wY-Bo for qemu-devel@nongnu.org; Fri, 13 Feb 2015 04:29:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YMCZH-00067y-O0 for qemu-devel@nongnu.org; Fri, 13 Feb 2015 04:29:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35550) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMCZH-00067t-HY for qemu-devel@nongnu.org; Fri, 13 Feb 2015 04:29:47 -0500 Message-ID: <54DDC400.9050905@redhat.com> Date: Fri, 13 Feb 2015 10:29:36 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1423758091-26462-1-git-send-email-mjrosato@linux.vnet.ibm.com> <54DCE440.6000609@redhat.com> <54DCFFB3.1070908@linux.vnet.ibm.com> <54DD1085.4030503@redhat.com> <54DD6FAE.2070500@linux.vnet.ibm.com> In-Reply-To: <54DD6FAE.2070500@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] memory: Fix double unref of flatview List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Matthew Rosato , Christian Borntraeger , Fam Zheng , qemu-devel On 13/02/2015 04:29, Matthew Rosato wrote: > FYI, then this probably also affects the places you hit in d8d9581460 > "memory: convert memory_region_destroy to object_unparent", as that's > what I modeled this approach on -- but I haven't tested any of them. Luckily not, because only "real" regions (not aliases and containers) end up in a FlatView. So you can do object_unparent on aliases and containers. It's ugly and should be avoided, but not buggy. There's only three cases (VFIO, for which patches have been posted and reviewed already, plus other two in PCI) that have to be modified. Paolo