All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Preeti U Murthy <preeti@linux.vnet.ibm.com>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
	jacob.jun.pan@intel.com, fweisbec@gmail.com, frederic@kernel.org,
	daniel.lezcano@linaro.org, amit.kucheria@linaro.org,
	edubezval@gmail.com, viresh.kumar@linaro.org,
	rui.zhang@intel.com
Subject: Re: [PATCH V2] idle/intel_powerclamp: Redesign idle injection to use bandwidth control mechanism
Date: Fri, 13 Feb 2015 06:03:38 -0800	[thread overview]
Message-ID: <54DE043A.9040605@linux.intel.com> (raw)
In-Reply-To: <20150213133158.GP2896@worktop.programming.kicks-ass.net>


> Also, exposing these and root_task_group is of course vile. Not to
> mention you change the user (cgroup) interface without mention.
>
> In any case, I cannot see how this could ever work. Bandwidth is shared
> across CPUs; nothing will even attempt to get CPUs to idle at the same
> time.

idle injection is only worth it if you can get package C states,
e.g. all cpus in the system are idle at the same time.

(and in powerclamp, the package C state %age is the target of the control
loop, since that's pretty much the amount of power reduced)

>
>


      reply	other threads:[~2015-02-13 14:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-09  4:49 [PATCH V2] idle/intel_powerclamp: Redesign idle injection to use bandwidth control mechanism Preeti U Murthy
2015-02-09  7:32 ` Steven Noonan
2015-02-09 11:51   ` Preeti U Murthy
2015-02-09 17:56     ` Steven Noonan
2015-02-09 18:14       ` Steven Noonan
2015-02-11  9:00         ` Preeti U Murthy
2015-02-13 13:31 ` Peter Zijlstra
2015-02-13 14:03   ` Arjan van de Ven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54DE043A.9040605@linux.intel.com \
    --to=arjan@linux.intel.com \
    --cc=amit.kucheria@linaro.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=edubezval@gmail.com \
    --cc=frederic@kernel.org \
    --cc=fweisbec@gmail.com \
    --cc=jacob.jun.pan@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=preeti@linux.vnet.ibm.com \
    --cc=rui.zhang@intel.com \
    --cc=tglx@linutronix.de \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.