From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v5 05/24] libxc: allocate memory with vNUMA information for PV guest Date: Fri, 13 Feb 2015 15:17:24 +0000 Message-ID: <54DE1584.8030505@citrix.com> References: <1423770294-9779-1-git-send-email-wei.liu2@citrix.com> <1423770294-9779-6-git-send-email-wei.liu2@citrix.com> <54DE0A86.7060900@citrix.com> <20150213150551.GD13644@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150213150551.GD13644@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: ian.campbell@citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, JBeulich@suse.com, ufimtseva@gmail.com List-Id: xen-devel@lists.xenproject.org On 13/02/15 15:05, Wei Liu wrote: > On Fri, Feb 13, 2015 at 02:30:30PM +0000, Andrew Cooper wrote: >> On 12/02/15 19:44, Wei Liu wrote: >>> diff --git a/tools/libxc/xc_private.h b/tools/libxc/xc_private.h >>> index 45b8644..1809674 100644 >>> --- a/tools/libxc/xc_private.h >>> +++ b/tools/libxc/xc_private.h >>> @@ -35,6 +35,8 @@ >>> >>> #include >>> >>> +#define XC_VNUMA_NO_NODE (~0U) >> Shouldn't this sentinel value come from the Xen public API? >> > Xen public headers don't have a NUMA_NO_NODE though. Do you want me > to add one to memory.h? Yes please. There are far too many sentinel values missing in the Xen public API which libxc has a different #define for (INVALID_MFN being the main one). Best not to make the situation any worse. ~Andrew