From: Guenter Roeck <linux@roeck-us.net>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Bas Peters <baspeters93@gmail.com>,
hch@lst.de, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
jim.epost@gmail.com
Subject: Re: [PATCH] fs: nfsd:xdr4.h: add missing conditional group CONFIG_NFSD_V3
Date: Fri, 13 Feb 2015 11:18:38 -0800 [thread overview]
Message-ID: <54DE4E0E.2000206@roeck-us.net> (raw)
In-Reply-To: <20150213173348.GD6808@fieldses.org>
On 02/13/2015 09:33 AM, J. Bruce Fields wrote:
[...]
>
>> Result is that every build with NFS configured but not NSFv3 is
>> now broken.
>
> Fortunately a v2-only server would be pretty unusual these days.
>
> I don't know, maybe this?
>
> --b.
>
> commit 535c381153631af3bc708a97e267a2a6a86ee030
> Author: J. Bruce Fields <bfields@redhat.com>
> Date: Fri Feb 13 12:27:39 2015 -0500
>
> nfsd4: fix v3-less build
>
> Includes of pnfs.h in export.c and fcntl.c also bring in xdr4.h, which
> won't build without CONFIG_NFSD_V3, breaking non-V3 builds. Ifdef-out
> most of pnfs.h in that case.
>
> Reported-by: Bas Peters <baspeters93@gmail.com>
> Reported-by: Jim Davis <jim.epost@gmail.com>
> Fixes: 9cf514ccfac "nfsd: implement pNFS operations"
> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Passes all my build and runtime tests.
Tested-by: Guenter Roeck <linux@roeck-us.net>
Guenter
prev parent reply other threads:[~2015-02-13 19:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 22:09 [PATCH] fs: nfsd:xdr4.h: add missing conditional group CONFIG_NFSD_V3 Bas Peters
[not found] ` <1423778953-28307-1-git-send-email-baspeters93-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-02-12 23:02 ` Guenter Roeck
2015-02-12 23:02 ` Guenter Roeck
[not found] ` <20150212230201.GB17998-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-02-13 14:51 ` J. Bruce Fields
2015-02-13 14:51 ` J. Bruce Fields
2015-02-13 16:52 ` Guenter Roeck
2015-02-13 17:33 ` J. Bruce Fields
2015-02-13 17:44 ` Guenter Roeck
2015-02-13 19:18 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DE4E0E.2000206@roeck-us.net \
--to=linux@roeck-us.net \
--cc=baspeters93@gmail.com \
--cc=bfields@fieldses.org \
--cc=hch@lst.de \
--cc=jim.epost@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.