All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gioh Kim <gioh.kim@lge.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Stefan Strogin <s.strogin@partner.samsung.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Michal Nazarewicz <mina86@mina86.com>,
	aneesh.kumar@linux.vnet.ibm.com,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Dmitry Safonov <d.safonov@partner.samsung.com>,
	Pintu Kumar <pintu.k@samsung.com>,
	Weijie Yang <weijie.yang@samsung.com>,
	Laura Abbott <lauraa@codeaurora.org>,
	SeongJae Park <sj38.park@gmail.com>, Hui Zhu <zhuhui@xiaomi.com>,
	Minchan Kim <minchan@kernel.org>,
	Dyasly Sergey <s.dyasly@samsung.com>,
	Vyacheslav Tyrtov <v.tyrtov@samsung.com>,
	gregory.0xf0@gmail.com, sasha.levin@oracle.com, pavel@ucw.cz,
	stefan.strogin@gmail.com
Subject: Re: [PATCH 0/4] mm: cma: add some debug information for CMA
Date: Sat, 14 Feb 2015 16:40:36 +0900	[thread overview]
Message-ID: <54DEFBF4.40206@lge.com> (raw)
In-Reply-To: <20150213030308.GG6592@js1304-P5Q-DELUXE>



2015-02-13 i??i?? 12:03i?? Joonsoo Kim i?'(e??) i?' e,?:
> On Fri, Feb 13, 2015 at 01:15:40AM +0300, Stefan Strogin wrote:
>> Hi all.
>>
>> Sorry for the long delay. Here is the second attempt to add some facility
>> for debugging CMA (the first one was "mm: cma: add /proc/cmainfo" [1]).
>>
>> This patch set is based on v3.19 and Sasha Levin's patch set
>> "mm: cma: debugfs access to CMA" [2].
>> It is also available on git:
>> git://github.com/stefanstrogin/cmainfo -b cmainfo-v2
>>
>> We want an interface to see a list of currently allocated CMA buffers and
>> some useful information about them (like /proc/vmallocinfo but for physically
>> contiguous buffers allocated with CMA).
>>
>> Here is an example use case when we need it. We want a big (megabytes)
>> CMA buffer to be allocated in runtime in default CMA region. If someone
>> already uses CMA then the big allocation can fail. If it happens then with
>> such an interface we could find who used CMA at the moment of failure, who
>> caused fragmentation (possibly ftrace also would be helpful here) and so on.
>
> Hello,
>
> So, I'm not sure that information about allocated CMA buffer is really
> needed to solve your problem. You just want to know who uses default CMA
> region and you can know it by adding tracepoint in your 4/4 patch. We
> really need this custom allocation tracer? What can we do more with
> this custom tracer to solve your problem? Could you more specific
> about your problem and how to solve it by using this custom tracer?
>
>>
>> These patches add some files to debugfs when CONFIG_CMA_DEBUGFS is enabled.
>
> If this tracer is justifiable, I think that making it conditional is
> better than just enabling always on CONFIG_CMA_DEBUGFS. Some users
> don't want to this feature although they enable CONFIG_CMA_DEBUGFS.
>
> Thanks.
>

Hello,

Thanks for your work. It must be helpful to me.

What about add another option to activate stack-trace?
In my platform I know all devices using cma area, so I usually don't need stack-trace.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Gioh Kim <gioh.kim@lge.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Stefan Strogin <s.strogin@partner.samsung.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Michal Nazarewicz <mina86@mina86.com>,
	aneesh.kumar@linux.vnet.ibm.com,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Dmitry Safonov <d.safonov@partner.samsung.com>,
	Pintu Kumar <pintu.k@samsung.com>,
	Weijie Yang <weijie.yang@samsung.com>,
	Laura Abbott <lauraa@codeaurora.org>,
	SeongJae Park <sj38.park@gmail.com>, Hui Zhu <zhuhui@xiaomi.com>,
	Minchan Kim <minchan@kernel.org>,
	Dyasly Sergey <s.dyasly@samsung.com>,
	Vyacheslav Tyrtov <v.tyrtov@samsung.com>,
	gregory.0xf0@gmail.com, sasha.levin@oracle.com, pavel@ucw.cz,
	stefan.strogin@gmail.com
Subject: Re: [PATCH 0/4] mm: cma: add some debug information for CMA
Date: Sat, 14 Feb 2015 16:40:36 +0900	[thread overview]
Message-ID: <54DEFBF4.40206@lge.com> (raw)
In-Reply-To: <20150213030308.GG6592@js1304-P5Q-DELUXE>



2015-02-13 오후 12:03에 Joonsoo Kim 이(가) 쓴 글:
> On Fri, Feb 13, 2015 at 01:15:40AM +0300, Stefan Strogin wrote:
>> Hi all.
>>
>> Sorry for the long delay. Here is the second attempt to add some facility
>> for debugging CMA (the first one was "mm: cma: add /proc/cmainfo" [1]).
>>
>> This patch set is based on v3.19 and Sasha Levin's patch set
>> "mm: cma: debugfs access to CMA" [2].
>> It is also available on git:
>> git://github.com/stefanstrogin/cmainfo -b cmainfo-v2
>>
>> We want an interface to see a list of currently allocated CMA buffers and
>> some useful information about them (like /proc/vmallocinfo but for physically
>> contiguous buffers allocated with CMA).
>>
>> Here is an example use case when we need it. We want a big (megabytes)
>> CMA buffer to be allocated in runtime in default CMA region. If someone
>> already uses CMA then the big allocation can fail. If it happens then with
>> such an interface we could find who used CMA at the moment of failure, who
>> caused fragmentation (possibly ftrace also would be helpful here) and so on.
>
> Hello,
>
> So, I'm not sure that information about allocated CMA buffer is really
> needed to solve your problem. You just want to know who uses default CMA
> region and you can know it by adding tracepoint in your 4/4 patch. We
> really need this custom allocation tracer? What can we do more with
> this custom tracer to solve your problem? Could you more specific
> about your problem and how to solve it by using this custom tracer?
>
>>
>> These patches add some files to debugfs when CONFIG_CMA_DEBUGFS is enabled.
>
> If this tracer is justifiable, I think that making it conditional is
> better than just enabling always on CONFIG_CMA_DEBUGFS. Some users
> don't want to this feature although they enable CONFIG_CMA_DEBUGFS.
>
> Thanks.
>

Hello,

Thanks for your work. It must be helpful to me.

What about add another option to activate stack-trace?
In my platform I know all devices using cma area, so I usually don't need stack-trace.

  reply	other threads:[~2015-02-14  7:40 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-12 22:15 [PATCH 0/4] mm: cma: add some debug information for CMA Stefan Strogin
2015-02-12 22:15 ` Stefan Strogin
2015-02-12 22:15 ` [PATCH 1/4] mm: cma: add currently allocated CMA buffers list to debugfs Stefan Strogin
2015-02-12 22:15   ` Stefan Strogin
2015-02-13  3:10   ` Joonsoo Kim
2015-02-13  3:10     ` Joonsoo Kim
2015-02-16 19:15     ` Stefan Strogin
2015-02-16 19:15       ` Stefan Strogin
2015-02-16 19:19     ` Stefan Strogin
2015-02-16 19:19       ` Stefan Strogin
2015-02-13  3:16   ` Joonsoo Kim
2015-02-13  3:16     ` Joonsoo Kim
2015-02-18 10:06     ` Stefan Strogin
2015-02-18 10:06       ` Stefan Strogin
2015-02-13 14:18   ` SeongJae Park
2015-02-13 14:18     ` SeongJae Park
2015-02-16 19:25     ` Stefan Strogin
2015-02-16 19:25       ` Stefan Strogin
2015-02-12 22:15 ` [PATCH 2/4] mm: cma: add functions to get region pages counters Stefan Strogin
2015-02-12 22:15   ` Stefan Strogin
2015-02-13  3:11   ` Joonsoo Kim
2015-02-13  3:11     ` Joonsoo Kim
2015-02-14  7:32   ` Gioh Kim
2015-02-14  7:32     ` Gioh Kim
2015-02-18 13:12     ` Safonov Dmitry
2015-02-18 13:12       ` Safonov Dmitry
2015-02-12 22:15 ` [PATCH 3/4] mm: cma: add number of pages to debug message in cma_release() Stefan Strogin
2015-02-12 22:15   ` Stefan Strogin
2015-02-12 22:15 ` [PATCH 4/4] mm: cma: add trace events to debug physically-contiguous memory allocations Stefan Strogin
2015-02-12 22:15   ` Stefan Strogin
2015-02-13  3:03 ` [PATCH 0/4] mm: cma: add some debug information for CMA Joonsoo Kim
2015-02-13  3:03   ` Joonsoo Kim
2015-02-14  7:40   ` Gioh Kim [this message]
2015-02-14  7:40     ` Gioh Kim
2015-02-16 19:29     ` Stefan Strogin
2015-02-16 19:29       ` Stefan Strogin
2015-02-22 23:29       ` Gioh Kim
2015-02-22 23:29         ` Gioh Kim
2015-02-16 18:53   ` Stefan Strogin
2015-02-16 18:53     ` Stefan Strogin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54DEFBF4.40206@lge.com \
    --to=gioh.kim@lge.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=d.safonov@partner.samsung.com \
    --cc=gregory.0xf0@gmail.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=lauraa@codeaurora.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mina86@mina86.com \
    --cc=minchan@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=pintu.k@samsung.com \
    --cc=s.dyasly@samsung.com \
    --cc=s.strogin@partner.samsung.com \
    --cc=sasha.levin@oracle.com \
    --cc=sj38.park@gmail.com \
    --cc=stefan.strogin@gmail.com \
    --cc=v.tyrtov@samsung.com \
    --cc=weijie.yang@samsung.com \
    --cc=zhuhui@xiaomi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.