From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMo1x-00005s-Vz for qemu-devel@nongnu.org; Sat, 14 Feb 2015 20:29:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YMo1q-000099-14 for qemu-devel@nongnu.org; Sat, 14 Feb 2015 20:29:53 -0500 Received: from szxga01-in.huawei.com ([119.145.14.64]:54741) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMo1p-00007M-Ez for qemu-devel@nongnu.org; Sat, 14 Feb 2015 20:29:45 -0500 Message-ID: <54DFF65A.3060305@huawei.com> Date: Sun, 15 Feb 2015 09:28:58 +0800 From: Linhaifeng MIME-Version: 1.0 References: <1423835139-9648-1-git-send-email-haifeng.lin@huawei.com> <1423835139-9648-2-git-send-email-haifeng.lin@huawei.com> <20150214210336.GA1281@redhat.com> In-Reply-To: <20150214210336.GA1281@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/3] vhost-user: update the protocol. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org On 2015/2/15 5:03, Michael S. Tsirkin wrote: > On Fri, Feb 13, 2015 at 09:45:37PM +0800, linhaifeng wrote: >> @@ -35,7 +39,7 @@ consists of 3 header fields and a payload: >> >> * Request: 32-bit type of the request >> * Flags: 32-bit bit field: >> - - Lower 2 bits are the version (currently 0x01) >> + - Lower 2 bits are the version (currently 0x06) >> - Bit 2 is the reply flag - needs to be sent on each reply from the slave >> * Size - 32-bit size of the payload >> > > How do you encode 0x6 in a 2 bit field? > I think the reply flag is unnecessary,so i remove it and let all the field as version. The existing version is 0x5 now. Sorry, i need to update the vhost-user.txt to describe it. -- Regards, Haifeng