From: Yunlong Song <yunlong.song@huawei.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: <a.p.zijlstra@chello.nl>, <paulus@samba.org>, <mingo@redhat.com>,
<linux-kernel@vger.kernel.org>, <wangnan0@huawei.com>
Subject: Re: [PATCH 5/7] perf list: avoid confusion of perf output and the next command prompt
Date: Sun, 15 Feb 2015 18:01:54 +0800 [thread overview]
Message-ID: <54E06E92.9090109@huawei.com> (raw)
In-Reply-To: <20150213145244.GS24251@kernel.org>
On 2015/2/13 22:52, Arnaldo Carvalho de Melo wrote:
> Em Fri, Feb 13, 2015 at 09:11:53PM +0800, Yunlong Song escreveu:
>> Distinguish the output of 'perf list --list-opts' or 'perf --list-cmds'
>> with the next command prompt, which also happens in other cases (e.g.
>> record, report ...).
>>
>> Example
>> Before this patch:
>> $perf list --list-opts
>> --raw-dump $ <-- the output and the next command prompt are at
>> the same line
>>
>> After this patch:
>> $perf list --list-opts
>> --raw-dump
>> $ <-- the new line
>
> Unsure about this one, IIRC this --list-opts thing was added to be used
> together with shell autocompletion, have you checked that this extra
> newline is OK with that?
>
> Please try searching for the changeset that introduced --list-opts to
> get info about how to test this,
>
> Thanks,
>
> - Arnaldo
>
> .
>
Already checked, it's really OK.
--
Thanks,
Yunlong Song
next prev parent reply other threads:[~2015-02-15 10:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 13:11 [PATCH 0/7] perf list: make some improvements and fixes Yunlong Song
2015-02-13 13:11 ` [PATCH 1/7] perf list: clean up the printing functions of hardware/software events Yunlong Song
2015-02-13 13:11 ` [PATCH 2/7] perf list: sort the output of 'perf list' to view more clearly Yunlong Song
2015-02-13 14:45 ` Arnaldo Carvalho de Melo
2015-02-13 14:49 ` Arnaldo Carvalho de Melo
2015-02-15 10:19 ` Yunlong Song
2015-02-15 10:11 ` Yunlong Song
2015-02-13 13:11 ` [PATCH 3/7] perf list: fix some inaccuracy problem when parsing the argument Yunlong Song
2015-02-13 13:11 ` [PATCH 4/7] perf list: fix a bug of segmentation fault Yunlong Song
2015-02-18 18:41 ` [tip:perf/core] perf tools: Fix " tip-bot for Yunlong Song
2015-02-13 13:11 ` [PATCH 5/7] perf list: avoid confusion of perf output and the next command prompt Yunlong Song
2015-02-13 14:52 ` Arnaldo Carvalho de Melo
2015-02-15 10:01 ` Yunlong Song [this message]
2015-02-13 13:11 ` [PATCH 6/7] perf list: extend raw-dump to certain kind of events Yunlong Song
2015-02-13 14:55 ` Arnaldo Carvalho de Melo
2015-02-15 10:05 ` Yunlong Song
2015-02-13 13:11 ` [PATCH 7/7] perf list: place the guiding text in its right position Yunlong Song
2015-02-18 18:42 ` [tip:perf/core] perf list: Place the header " tip-bot for Yunlong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E06E92.9090109@huawei.com \
--to=yunlong.song@huawei.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.