From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Thomas Graf <tgraf@suug.ch>, Joe Stringer <joestringer@nicira.com>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
Justin Pettit <jpettit@nicira.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
"dev@openvswitch.org" <dev@openvswitch.org>
Subject: Re: [RFC net-next 3/4] openvswitch: Add conntrack action.
Date: Sun, 15 Feb 2015 20:51:59 +0100 [thread overview]
Message-ID: <54E0F8DF.1060602@6wind.com> (raw)
In-Reply-To: <20150215191356.GA14888@casper.infradead.org>
Le 15/02/2015 20:13, Thomas Graf a écrit :
> On 02/15/15 at 11:06am, Joe Stringer wrote:
>> On 15 February 2015 at 07:08, Nicolas Dichtel <nicolas.dichtel@6wind.com> wrote:
>>> Le 15/02/2015 05:47, Joe Stringer a écrit :
>>>> Right, it was more of a general sanity check which is likely unneeded.
>>>> I'm not aware of any particular case that this handles.
>>>
>>> I agree with Thomas. If we fall into this case, it's probably a real bug ;-)
>>
>> We can BUG_ON(), then.
>
> Let's do a WARN() and just error so we keep the kernel running ;-)
Yes. I wonder if there are more generic places to do this kind of check, because
I don't think that this kind of bug will be specific to ovs.
next prev parent reply other threads:[~2015-02-15 19:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-14 8:13 [RFC net-next 0/4] OVS conntrack support Joe Stringer
2015-02-14 8:13 ` [RFC net-next 1/4] openvswitch: Serialize acts with original netlink len Joe Stringer
2015-02-14 8:13 ` [RFC net-next 2/4] openvswitch: Move MASKED* macros to datapath.h Joe Stringer
2015-02-14 8:13 ` [RFC net-next 3/4] openvswitch: Add conntrack action Joe Stringer
2015-02-14 8:20 ` Joe Stringer
2015-02-14 19:56 ` Thomas Graf
[not found] ` <20150214195607.GA30752-FZi0V3Vbi30CUdFEqe4BF2D2FQJk+8+b@public.gmane.org>
2015-02-15 4:47 ` Joe Stringer
2015-02-15 15:08 ` Nicolas Dichtel
[not found] ` <54E0B67A.1030000-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-02-15 19:06 ` Joe Stringer
2015-02-15 19:13 ` Thomas Graf
2015-02-15 19:51 ` Nicolas Dichtel [this message]
2015-02-14 8:13 ` [RFC net-next 4/4] openvswitch: Allow matching on conntrack mark Joe Stringer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E0F8DF.1060602@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=dev@openvswitch.org \
--cc=joestringer@nicira.com \
--cc=jpettit@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.