From: Daniel Thompson <daniel.thompson@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>, linaro-kernel@lists.linaro.org
Cc: Christoph Hellwig <hch@lst.de>,
patches@linaro.org, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org,
"J. Bruce Fields" <bfields@fieldses.org>
Subject: Re: [PATCH] nfsd: Fix v2-only build regression
Date: Mon, 16 Feb 2015 05:24:40 +0000 [thread overview]
Message-ID: <54E17F18.8070809@linaro.org> (raw)
In-Reply-To: <2435499.xPpCe4zRXk@wuerfel>
On 16/02/15 11:54, Arnd Bergmann wrote:
> On Monday 16 February 2015 11:36:03 Daniel Thompson wrote:
>> Currently if nfsd is configured as v2 only then the kernel fails to build.
>> This is a regression introduced by 9cf514ccfacb("nfsd: implement pNFS
>> operations"). It occurs because inline code from the xdr4.h header is
>> now included from generic nfsd code (via pnfs.h).
>>
>> This patch takes the simplest route and makes conditional the problematic
>> inline function.
>>
>> Note: I also tried extending the #ifdef CONFIG_NFSD_PNFS to cover almost
>> all of the pnfs.h header file. That works great too but feels more
>> invasive. However I can dust this off if that were preferable for
>> any reason.
>>
>
> I believe this was fixed last Friday in the patch below. Do you still
> see the problem on today's linux-next?
Thanks Arnd. I overlooked this patch (which didn't pop out very clearly
in the google searches I did).
It is fixed in linux-next.
Daniel.
prev parent reply other threads:[~2015-02-16 13:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 11:36 [PATCH] nfsd: Fix v2-only build regression Daniel Thompson
2015-02-16 11:54 ` Arnd Bergmann
2015-02-16 5:24 ` Daniel Thompson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E17F18.8070809@linaro.org \
--to=daniel.thompson@linaro.org \
--cc=arnd@arndb.de \
--cc=bfields@fieldses.org \
--cc=hch@lst.de \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.