From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNI0n-0000ce-JS for qemu-devel@nongnu.org; Mon, 16 Feb 2015 04:30:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNI0j-0002Zv-IW for qemu-devel@nongnu.org; Mon, 16 Feb 2015 04:30:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38907) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNI0j-0002Zp-C3 for qemu-devel@nongnu.org; Mon, 16 Feb 2015 04:30:37 -0500 Message-ID: <54E1B8B0.5060705@redhat.com> Date: Mon, 16 Feb 2015 10:30:24 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1423999136-17320-1-git-send-email-mst@redhat.com> <1423999136-17320-11-git-send-email-mst@redhat.com> In-Reply-To: <1423999136-17320-11-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 10/17] virtio-scsi: use standard-headers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: Peter Maydell , Stefan Hajnoczi , Alexander Graf , Anthony Liguori , Cornelia Huck , "Chen, Tiejun" On 15/02/2015 12:39, Michael S. Tsirkin wrote: > Drop duplicated code. > > Signed-off-by: Michael S. Tsirkin > --- > include/hw/virtio/virtio-scsi.h | 120 +++------------------------------------- > hw/scsi/virtio-scsi.c | 1 + > 2 files changed, 10 insertions(+), 111 deletions(-) > > diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h > index bf17cc9..9bcda7e 100644 > --- a/include/hw/virtio/virtio-scsi.h > +++ b/include/hw/virtio/virtio-scsi.h > @@ -14,6 +14,7 @@ > #ifndef _QEMU_VIRTIO_SCSI_H > #define _QEMU_VIRTIO_SCSI_H > > +#include "standard-headers/sys/virtio_scsi.h" Why sys/? It's linux/, let's keep it linux/. Paolo