From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH] Add Q variable to external builds to be quite Date: Mon, 16 Feb 2015 15:15:17 +0100 Message-ID: <54E1FB75.8090404@6wind.com> References: <1423937607-35845-1-git-send-email-keith.wiles@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: Keith Wiles , dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <1423937607-35845-1-git-send-email-keith.wiles-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Keith, On 02/14/2015 07:13 PM, Keith Wiles wrote: > Signed-off-by: Keith Wiles > --- > mk/rte.extvars.mk | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/mk/rte.extvars.mk b/mk/rte.extvars.mk > index 3e5a990..83a5721 100644 > --- a/mk/rte.extvars.mk > +++ b/mk/rte.extvars.mk > @@ -66,6 +66,10 @@ endif > RTE_OUTPUT ?= $(RTE_SRCDIR)/build > export RTE_OUTPUT > > +# define Q to '@' or not. $(Q) is used to prefix all shell commands to > +# be executed silently. > +Q=@ > + > # if we are building an external application, include SDK > # configuration and include project configuration if any > include $(RTE_SDK_BIN)/.config > In the examples/ directory, rte.extvars.mk is never included directly. They use rte.vars.mk, which already properly defines the $(Q) variable (its value depends on V= argument). So I think we don't need this patch. Regards, Olivier