From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YNNH5-0006wB-DG for mharc-grub-devel@gnu.org; Mon, 16 Feb 2015 10:07:51 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41742) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNNGz-0006w3-SE for grub-devel@gnu.org; Mon, 16 Feb 2015 10:07:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNNGx-0005gj-CK for grub-devel@gnu.org; Mon, 16 Feb 2015 10:07:45 -0500 Received: from mail-we0-x231.google.com ([2a00:1450:400c:c03::231]:47105) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNNGx-0005gX-1S for grub-devel@gnu.org; Mon, 16 Feb 2015 10:07:43 -0500 Received: by mail-we0-f177.google.com with SMTP id m14so23907043wev.8 for ; Mon, 16 Feb 2015 07:07:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=vnOc2Hk5kDD4Yyx/VQyTu+uZe98UPljlDT9o0RMzyrk=; b=G+cU6EKscPPe+zE/2LyteMIZEfJ9JLNvdrZjk42rRGFWwnm09YA/LaRBt93IIkACfD ts/bIwyimXvjoJoOtSWLkpBCpPXlRM8xpAmaE5XrGn9C/tX5iazsYx3iYeR5e5wLEB2h UAkpF15UzdloaiMsXZkqWpb2mqvcm9OBt7Ttz45Hekm/DYer5x/D2bskctuKQtIy0Uvm EZMGBMRrClcRlE09Gkg7mKhhFYaZezkwhvlzNCBJbcYHK1qCBis/l9i4hr1+XmXikUUG zC2GUXAO6brXDN/fdN3nOvy/HbaFi63gGKmkiYYCbAj5ZVVKwT3+ErWv4NvOqglvywL9 qtJg== X-Received: by 10.180.211.101 with SMTP id nb5mr45710048wic.37.1424099262543; Mon, 16 Feb 2015 07:07:42 -0800 (PST) Received: from ?IPv6:2620:0:105f:fd00:202:52ff:fe61:c42e? ([2620:0:105f:fd00:202:52ff:fe61:c42e]) by mx.google.com with ESMTPSA id lu13sm20067645wic.10.2015.02.16.07.07.41 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Feb 2015 07:07:41 -0800 (PST) Message-ID: <54E207B8.6030607@gmail.com> Date: Mon, 16 Feb 2015 16:07:36 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [bug #44239] Behavior of syslinux_parse differs from SYSLINUX for initrd= option References: <20150213-163645.sv98365.99674@savannah.gnu.org> <20150213-191419.sv89796.29507@savannah.gnu.org> <20150213203232.GG688@loar> In-Reply-To: <20150213203232.GG688@loar> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kTdBu206qEqwEXgQhltoQIglKEVvEjtvE" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c03::231 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 15:07:49 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kTdBu206qEqwEXgQhltoQIglKEVvEjtvE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 13.02.2015 21:32, Lunar wrote: > Andrei Borzenkov: >> Follow-up Comment #1, bug #44239 (project grub): >> >> Can't comment about behavior itself. Re. patch >> >> + cmdline =3D grub_strdup(curentry->append); >> Error check missing. >> >> + grub_free(cmdline); >> You need to delete free(cmdline) later. >=20 > Both fixed. >=20 >> Again, can you post updated version to grub-devel for easier review? >=20 > Here it is. >=20 The code at this place turned out to be not very understandable. I simplified the code and did the change you requested. >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 --kTdBu206qEqwEXgQhltoQIglKEVvEjtvE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iF4EAREKAAYFAlTiB7gACgkQmBXlbbo5nOvKrQD+JpO7C5PvkAa8d7eTfRNF7OnW J6EiI1tar2gKxuCVLosA/AiwHwB7BUuwO6cwRcr8mBDodYDBeHSGuyEvZdzkzZJw =Pvnm -----END PGP SIGNATURE----- --kTdBu206qEqwEXgQhltoQIglKEVvEjtvE--