All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Alan Fisher <acf@unixcube.org>,
	linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: PROBLEM: rtlwifi drops most IPv6 packets
Date: Mon, 16 Feb 2015 12:26:44 -0600	[thread overview]
Message-ID: <54E23664.70509@lwfinger.net> (raw)
In-Reply-To: <54E19DD6.9050704@unixcube.org>

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

On 02/16/2015 01:35 AM, Alan Fisher wrote:

Alan,

I looked at the routine, and it is returning true for all IPv6 packets.

Does the attached patch for 3.18 or 3.19 help?

Larry


[-- Attachment #2: modify_is_special_data --]
[-- Type: text/plain, Size: 805 bytes --]

Index: wireless-drivers-next/drivers/net/wireless/rtlwifi/base.c
===================================================================
--- wireless-drivers-next.orig/drivers/net/wireless/rtlwifi/base.c
+++ wireless-drivers-next/drivers/net/wireless/rtlwifi/base.c
@@ -1347,7 +1347,7 @@ u8 rtl_is_special_data(struct ieee80211_
 	offset = mac_hdr_len + SNAP_SIZE + encrypt_header_len;
 	ether_type = be16_to_cpup((__be16 *)(skb->data + offset));
 
-	if (ETH_P_IP == ether_type) {
+	if (ETH_P_IP == ether_type || ETH_P_IPV6 == ether_type) {
 		ip = (struct iphdr *)((u8 *)skb->data + offset +
 		     PROTOC_TYPE_SIZE);
 		if (IPPROTO_UDP == ip->protocol) {
@@ -1386,8 +1386,6 @@ u8 rtl_is_special_data(struct ieee80211_
 		}
 
 		return true;
-	} else if (0x86DD == ether_type) {
-		return true;
 	}
 
 end:

  parent reply	other threads:[~2015-02-16 18:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-16  7:35 PROBLEM: rtlwifi drops most IPv6 packets Alan Fisher
2015-02-16 16:57 ` Larry Finger
2015-02-16 18:26 ` Larry Finger [this message]
2015-02-17  8:29   ` Alan Fisher
2015-02-17 16:43     ` Larry Finger
2015-02-22 22:49       ` Alan Fisher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54E23664.70509@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=acf@unixcube.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.