All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Strogin <s.strogin@partner.samsung.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Michal Nazarewicz <mina86@mina86.com>,
	aneesh.kumar@linux.vnet.ibm.com,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Dmitry Safonov <d.safonov@partner.samsung.com>,
	Pintu Kumar <pintu.k@samsung.com>,
	Weijie Yang <weijie.yang@samsung.com>,
	Laura Abbott <lauraa@codeaurora.org>,
	SeongJae Park <sj38.park@gmail.com>, Hui Zhu <zhuhui@xiaomi.com>,
	Minchan Kim <minchan@kernel.org>,
	Dyasly Sergey <s.dyasly@samsung.com>,
	Vyacheslav Tyrtov <v.tyrtov@samsung.com>,
	gregory.0xf0@gmail.com, sasha.levin@oracle.com, gioh.kim@lge.com,
	pavel@ucw.cz, stefan.strogin@gmail.com
Subject: Re: [PATCH 1/4] mm: cma: add currently allocated CMA buffers list to debugfs
Date: Mon, 16 Feb 2015 22:15:03 +0300	[thread overview]
Message-ID: <54E241B7.1070709@partner.samsung.com> (raw)
In-Reply-To: <20150213031012.GH6592@js1304-P5Q-DELUXE>

Hello,

On 13/02/15 06:10, Joonsoo Kim wrote:
> On Fri, Feb 13, 2015 at 01:15:41AM +0300, Stefan Strogin wrote:
> 
> This linear searching make cma_release() slow if we have many allocated
> cma buffers. It wouldn't cause any problem?
> 
> Thanks.
> 
> 

On my board the usual number of CMA buffers is about 20, and releasing a
buffer isn't a very frequent operation.
But if there could be systems with much more CMA buffers and/or frequent
allocating/releasing them, maybe it would be useful to convert buffers
list to rb_trees?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Stefan Strogin <s.strogin@partner.samsung.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Michal Nazarewicz <mina86@mina86.com>,
	aneesh.kumar@linux.vnet.ibm.com,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Dmitry Safonov <d.safonov@partner.samsung.com>,
	Pintu Kumar <pintu.k@samsung.com>,
	Weijie Yang <weijie.yang@samsung.com>,
	Laura Abbott <lauraa@codeaurora.org>,
	SeongJae Park <sj38.park@gmail.com>, Hui Zhu <zhuhui@xiaomi.com>,
	Minchan Kim <minchan@kernel.org>,
	Dyasly Sergey <s.dyasly@samsung.com>,
	Vyacheslav Tyrtov <v.tyrtov@samsung.com>,
	gregory.0xf0@gmail.com, sasha.levin@oracle.com, gioh.kim@lge.com,
	pavel@ucw.cz, stefan.strogin@gmail.com
Subject: Re: [PATCH 1/4] mm: cma: add currently allocated CMA buffers list to debugfs
Date: Mon, 16 Feb 2015 22:15:03 +0300	[thread overview]
Message-ID: <54E241B7.1070709@partner.samsung.com> (raw)
In-Reply-To: <20150213031012.GH6592@js1304-P5Q-DELUXE>

Hello,

On 13/02/15 06:10, Joonsoo Kim wrote:
> On Fri, Feb 13, 2015 at 01:15:41AM +0300, Stefan Strogin wrote:
> 
> This linear searching make cma_release() slow if we have many allocated
> cma buffers. It wouldn't cause any problem?
> 
> Thanks.
> 
> 

On my board the usual number of CMA buffers is about 20, and releasing a
buffer isn't a very frequent operation.
But if there could be systems with much more CMA buffers and/or frequent
allocating/releasing them, maybe it would be useful to convert buffers
list to rb_trees?

  reply	other threads:[~2015-02-16 19:15 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-12 22:15 [PATCH 0/4] mm: cma: add some debug information for CMA Stefan Strogin
2015-02-12 22:15 ` Stefan Strogin
2015-02-12 22:15 ` [PATCH 1/4] mm: cma: add currently allocated CMA buffers list to debugfs Stefan Strogin
2015-02-12 22:15   ` Stefan Strogin
2015-02-13  3:10   ` Joonsoo Kim
2015-02-13  3:10     ` Joonsoo Kim
2015-02-16 19:15     ` Stefan Strogin [this message]
2015-02-16 19:15       ` Stefan Strogin
2015-02-16 19:19     ` Stefan Strogin
2015-02-16 19:19       ` Stefan Strogin
2015-02-13  3:16   ` Joonsoo Kim
2015-02-13  3:16     ` Joonsoo Kim
2015-02-18 10:06     ` Stefan Strogin
2015-02-18 10:06       ` Stefan Strogin
2015-02-13 14:18   ` SeongJae Park
2015-02-13 14:18     ` SeongJae Park
2015-02-16 19:25     ` Stefan Strogin
2015-02-16 19:25       ` Stefan Strogin
2015-02-12 22:15 ` [PATCH 2/4] mm: cma: add functions to get region pages counters Stefan Strogin
2015-02-12 22:15   ` Stefan Strogin
2015-02-13  3:11   ` Joonsoo Kim
2015-02-13  3:11     ` Joonsoo Kim
2015-02-14  7:32   ` Gioh Kim
2015-02-14  7:32     ` Gioh Kim
2015-02-18 13:12     ` Safonov Dmitry
2015-02-18 13:12       ` Safonov Dmitry
2015-02-12 22:15 ` [PATCH 3/4] mm: cma: add number of pages to debug message in cma_release() Stefan Strogin
2015-02-12 22:15   ` Stefan Strogin
2015-02-12 22:15 ` [PATCH 4/4] mm: cma: add trace events to debug physically-contiguous memory allocations Stefan Strogin
2015-02-12 22:15   ` Stefan Strogin
2015-02-13  3:03 ` [PATCH 0/4] mm: cma: add some debug information for CMA Joonsoo Kim
2015-02-13  3:03   ` Joonsoo Kim
2015-02-14  7:40   ` Gioh Kim
2015-02-14  7:40     ` Gioh Kim
2015-02-16 19:29     ` Stefan Strogin
2015-02-16 19:29       ` Stefan Strogin
2015-02-22 23:29       ` Gioh Kim
2015-02-22 23:29         ` Gioh Kim
2015-02-16 18:53   ` Stefan Strogin
2015-02-16 18:53     ` Stefan Strogin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54E241B7.1070709@partner.samsung.com \
    --to=s.strogin@partner.samsung.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=d.safonov@partner.samsung.com \
    --cc=gioh.kim@lge.com \
    --cc=gregory.0xf0@gmail.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=lauraa@codeaurora.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mina86@mina86.com \
    --cc=minchan@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=pintu.k@samsung.com \
    --cc=s.dyasly@samsung.com \
    --cc=sasha.levin@oracle.com \
    --cc=sj38.park@gmail.com \
    --cc=stefan.strogin@gmail.com \
    --cc=v.tyrtov@samsung.com \
    --cc=weijie.yang@samsung.com \
    --cc=zhuhui@xiaomi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.