From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com [209.85.220.49]) by kanga.kvack.org (Postfix) with ESMTP id 890696B0032 for ; Mon, 16 Feb 2015 14:15:11 -0500 (EST) Received: by padhz1 with SMTP id hz1so439744pad.9 for ; Mon, 16 Feb 2015 11:15:11 -0800 (PST) Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com. [210.118.77.14]) by mx.google.com with ESMTPS id ol6si1841113pbb.116.2015.02.16.11.15.09 for (version=TLSv1 cipher=RC4-MD5 bits=128/128); Mon, 16 Feb 2015 11:15:10 -0800 (PST) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NJV00NYOPNT3WA0@mailout4.w1.samsung.com> for linux-mm@kvack.org; Mon, 16 Feb 2015 19:19:05 +0000 (GMT) Message-id: <54E241B7.1070709@partner.samsung.com> Date: Mon, 16 Feb 2015 22:15:03 +0300 From: Stefan Strogin MIME-version: 1.0 Subject: Re: [PATCH 1/4] mm: cma: add currently allocated CMA buffers list to debugfs References: <20150213031012.GH6592@js1304-P5Q-DELUXE> In-reply-to: <20150213031012.GH6592@js1304-P5Q-DELUXE> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Joonsoo Kim Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Marek Szyprowski , Michal Nazarewicz , aneesh.kumar@linux.vnet.ibm.com, Laurent Pinchart , Dmitry Safonov , Pintu Kumar , Weijie Yang , Laura Abbott , SeongJae Park , Hui Zhu , Minchan Kim , Dyasly Sergey , Vyacheslav Tyrtov , gregory.0xf0@gmail.com, sasha.levin@oracle.com, gioh.kim@lge.com, pavel@ucw.cz, stefan.strogin@gmail.com Hello, On 13/02/15 06:10, Joonsoo Kim wrote: > On Fri, Feb 13, 2015 at 01:15:41AM +0300, Stefan Strogin wrote: > > This linear searching make cma_release() slow if we have many allocated > cma buffers. It wouldn't cause any problem? > > Thanks. > > On my board the usual number of CMA buffers is about 20, and releasing a buffer isn't a very frequent operation. But if there could be systems with much more CMA buffers and/or frequent allocating/releasing them, maybe it would be useful to convert buffers list to rb_trees? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754222AbbBPTPJ (ORCPT ); Mon, 16 Feb 2015 14:15:09 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:8537 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753812AbbBPTPH (ORCPT ); Mon, 16 Feb 2015 14:15:07 -0500 X-AuditID: cbfec7f5-b7fc86d0000066b7-4e-54e24125ee4b Message-id: <54E241B7.1070709@partner.samsung.com> Date: Mon, 16 Feb 2015 22:15:03 +0300 From: Stefan Strogin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-version: 1.0 To: Joonsoo Kim Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Marek Szyprowski , Michal Nazarewicz , aneesh.kumar@linux.vnet.ibm.com, Laurent Pinchart , Dmitry Safonov , Pintu Kumar , Weijie Yang , Laura Abbott , SeongJae Park , Hui Zhu , Minchan Kim , Dyasly Sergey , Vyacheslav Tyrtov , gregory.0xf0@gmail.com, sasha.levin@oracle.com, gioh.kim@lge.com, pavel@ucw.cz, stefan.strogin@gmail.com Subject: Re: [PATCH 1/4] mm: cma: add currently allocated CMA buffers list to debugfs References: <20150213031012.GH6592@js1304-P5Q-DELUXE> In-reply-to: <20150213031012.GH6592@js1304-P5Q-DELUXE> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrLIsWRmVeSWpSXmKPExsVy+t/xa7qqjo9CDN7e0bGYs34Nm8Xj1/NY LD6tfMpm8azpC6PFtOkbWC1WdjezWWzvnMFu0TlxCbvF5V1z2CzurfnParH2yF12iwXHW1gt ln19z25x99RRNou+74fZLSbPlrL4dnIOs8XiI7eZLa7t6GeyuPzmP7vF1Bk/2C1ObjjLarGh mctB3ONyXy+Tx85Zd9k9ZnfMZPXYtKqTzWPTp0nsHl1vrzB5nJjxm8XjwaHNLB7r/rxi8vj4 9BaLx8F3e5g8+rasYvRYsfo7u8fnTXIeXRt/sQbwR3HZpKTmZJalFunbJXBl/GpqZS5YzFJx 4v8s5gbGDcxdjJwcEgImEl8OTGaDsMUkLtxbD2RzcQgJLGWU2Ht7BSuE85FRYvPSHWBVvAJG EttXnAbrZhFQlZjWcYsVxGYDmnTswnRGEFtUIEJi/rHXzBD1ghI/Jt9jAbFFBDQkVq/azAwy lFngAavEgTUrgRwODmGBcIkDP4ohlh1jlNi3cCnYMk4BM4lJr88ygdQwC+hJ3L+oBRJmFpCX 2LzmLfMERoFZSFbMQqiahaRqASPzKkbR1NLkguKk9FwjveLE3OLSvHS95PzcTYyQKP+6g3Hp MatDjAIcjEo8vBdMHoUIsSaWFVfmHmKU4GBWEuENkQYK8aYkVlalFuXHF5XmpBYfYmTi4JRq YBR2ulpwUn3KxXMxD5mtp8katrHZXkxpivZ7Yz5jou3tC2z7TFWalfn8JzPd5DwovL7/dWNt ZhBvfOZ1QakE3jmnYs23+vxx2C1x7/8Jq5AbBuqXFDsXOi18LiRVNTlq7xnO1K97ZFI0c255 TGQvmdHXs29fl43g85vbbGpuzvC3ut9wo0GxW4mlOCPRUIu5qDgRAKMannfQAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 13/02/15 06:10, Joonsoo Kim wrote: > On Fri, Feb 13, 2015 at 01:15:41AM +0300, Stefan Strogin wrote: > > This linear searching make cma_release() slow if we have many allocated > cma buffers. It wouldn't cause any problem? > > Thanks. > > On my board the usual number of CMA buffers is about 20, and releasing a buffer isn't a very frequent operation. But if there could be systems with much more CMA buffers and/or frequent allocating/releasing them, maybe it would be useful to convert buffers list to rb_trees?