From: Chanwoo Choi <cw00.choi@samsung.com>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: cw00.choi@samsung.com, Chanwoo Choi <cwchoi00@gmail.com>,
"myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
patches@opensource.wolfsonmicro.com,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] extcon: arizona: Deobfuscate arizona_extcon_do_magic
Date: Tue, 17 Feb 2015 08:58:47 +0900 [thread overview]
Message-ID: <54E28437.3080105@samsung.com> (raw)
In-Reply-To: <CAGTfZH3J6u0MpJdd4kxY31OFHqo8QU2-2t0LzKgxUYP1b5qdEw@mail.gmail.com>
Hi Charles,
On 02/17/2015 01:48 AM, Chanwoo Choi wrote:
> Hi Charles,
>
>
> On Tue, Feb 17, 2015 at 12:41 AM, Charles Keepax
> <ckeepax@opensource.wolfsonmicro.com> wrote:
>> arizona_extcon_do_magic does not lend a lot of clarity to the purpose
>> of the function, and as all the registers used are described in the
>> datasheet there is no need to obfuscate the code. This patch renames the
>> function to arizona_extcon_hp_clamp, as it controls clamping on the
>> headphone output.
>>
>> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
>> ---
>> drivers/extcon/extcon-arizona.c | 36 ++++++++++++++++++++----------------
>> include/linux/mfd/arizona/core.h | 2 +-
>> sound/soc/codecs/arizona.c | 4 ++--
>> 3 files changed, 23 insertions(+), 19 deletions(-)
>
>
> Looks good to me.
> But, you need more ack message by MFD maintainer.
>
> For extcon part:
> Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Applied it.
Thanks,
Chanwoo Choi
next prev parent reply other threads:[~2015-02-16 23:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 15:41 [PATCH 1/2] extcon: arizona: Deobfuscate arizona_extcon_do_magic Charles Keepax
2015-02-16 15:41 ` [PATCH 2/2] extcon: arizona: Fix headphone clamping on wm5110 Charles Keepax
2015-02-16 16:49 ` Chanwoo Choi
2015-02-16 16:48 ` [PATCH 1/2] extcon: arizona: Deobfuscate arizona_extcon_do_magic Chanwoo Choi
2015-02-16 23:58 ` Chanwoo Choi [this message]
2015-02-16 16:50 ` Lee Jones
2015-02-17 1:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E28437.3080105@samsung.com \
--to=cw00.choi@samsung.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=cwchoi00@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.