Re: [Qemu-devel] [PATCH v7 07/10] qmp: add rocker device support

[David Ahern <dsahern@gmail.com>]

On 2/16/15 3:37 PM, Scott Feldman wrote:
> On Mon, Feb 16, 2015 at 5:16 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>>
>> On 16/02/2015 22:47, sfeldma@gmail.com wrote:
>>> From: Scott Feldman <sfeldma@gmail.com>
>>>
>>> Add QMP/HMP support for rocker devices.  This is mostly for debugging purposes
>>> to see inside the device's tables and port configurations.  Some examples:
>>>
>>> (qemu) info rocker sw1
>>> name: sw1
>>> id: 0x0000013512005452
>>> ports: 4
>>
>> I think CONFIG_ROCKER doesn't work as intended.  It's not exported to C
>> files.
>
> It's working fine.  What do you think it broken?

If you take out CONFIG_ROCKER (e.g., from default-configs/pci.mak or 
./x86_64-softmmu/config-devices.mak) you get:

   LINK  x86_64-softmmu/qemu-system-x86_64
../qmp-marshal.o: In function `qmp_marshal_input_query_rocker':
/home/dahern/sw/kvm/qemu.git/build/qmp-marshal.c:5591: undefined 
reference to `qmp_query_rocker'
../qmp-marshal.o: In function `qmp_marshal_input_query_rocker_ports':
/home/dahern/sw/kvm/qemu.git/build/qmp-marshal.c:5652: undefined 
reference to `qmp_query_rocker_ports'
../qmp-marshal.o: In function `qmp_marshal_input_query_rocker_of_dpa_flows':
/home/dahern/sw/kvm/qemu.git/build/qmp-marshal.c:5725: undefined 
reference to `qmp_query_rocker_of_dpa_flows'
../qmp-marshal.o: In function 
`qmp_marshal_input_query_rocker_of_dpa_groups':
/home/dahern/sw/kvm/qemu.git/build/qmp-marshal.c:5802: undefined 
reference to `qmp_query_rocker_of_dpa_groups'
collect2: error: ld returned 1 exit status
Makefile:180: recipe for target 'qemu-system-x86_64' failed
make[1]: *** [qemu-system-x86_64] Error 1
Makefile:169: recipe for target 'subdir-x86_64-softmmu' failed
make: *** [subdir-x86_64-softmmu] Error 2

>
>> I would just merge the other nine patches for 2.3.
>
> I disagree.  qmp/hmp is very important to rocker.  It would be nearly
> impossible to debug large/complicated networking setups without having
> a back-door view into the device.  qmp/hmp are perfect for this.
> Since rocker's primary purpose is for development of OS support for
> traditional L2/L3 offloads as well as flow-based offloads, it is
> important to enable this debug tool.

Taking all of them but QMP should lighten the review load and re-do on 
the patch set to load to just the qmp changes.

David