From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tetsuya Mukawa Subject: Re: [PATCH v8 05/14] ethdev: Add rte_eth_dev_free to free specified device Date: Tue, 17 Feb 2015 15:15:07 +0900 Message-ID: <54E2DC6B.8000409@igel.co.jp> References: <1423470639-15744-2-git-send-email-mukawa@igel.co.jp> <1424060073-23484-1-git-send-email-mukawa@igel.co.jp> <1424060073-23484-6-git-send-email-mukawa@igel.co.jp> <5935372.TlW161azlx@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Cc: dev-VfR2kkLFssw@public.gmane.org To: Thomas Monjalon Return-path: In-Reply-To: <5935372.TlW161azlx@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 2015/02/17 9:46, Thomas Monjalon wrote: > 2015-02-16 13:14, Tetsuya Mukawa: >> This patch adds rte_eth_dev_free(). The function is used for changing = an >> attached status of the device that has specified name. >> >> v6: >> - Use rte_eth_dev structure as the paramter of rte_eth_dev_free(). >> v4: >> - Add parameter checking. >> >> Signed-off-by: Tetsuya Mukawa >> --- >> lib/librte_ether/rte_ethdev.c | 11 +++++++++++ >> lib/librte_ether/rte_ethdev.h | 14 ++++++++++++++ >> 2 files changed, 25 insertions(+) >> >> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethd= ev.c >> index a79fa5b..2463d18 100644 >> --- a/lib/librte_ether/rte_ethdev.c >> +++ b/lib/librte_ether/rte_ethdev.c >> @@ -260,6 +260,17 @@ rte_eth_dev_allocate(const char *name) >> return eth_dev; >> } >> =20 >> +int >> +rte_eth_dev_free(struct rte_eth_dev *eth_dev) >> +{ >> + if (eth_dev =3D=3D NULL) >> + return -EINVAL; >> + >> + eth_dev->attached =3D 0; >> + nb_ports--; >> + return 0; >> +} > This function is strange. I would imagine it calling the free (uninit) = function > of the driver. How about changing the name like below? rte_eth_dev_release_port() > [...] >> +/** >> + * Function for internal use by dummy drivers primarily, e.g. ring-ba= sed >> + * driver. >> + * Free the specified ethdev. >> + * >> + * @param eth_dev >> + * The *eth_dev* pointer is the address of the *rte_eth_dev* structur= e >> + * associated with the matching device and which have been [automat= ically] >> + * allocated in the *rte_eth_devices* array. >> + * @return >> + * - 0 on success, negative on error >> + */ >> +int rte_eth_dev_free(struct rte_eth_dev *eth_dev); >> + >> struct eth_driver; >> /** >> * @internal >> >