All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Joseph Kogut <joseph.kogut@gmail.com>, gregkh@linuxfoundation.org
Cc: balbi@ti.com, johnyoun@synopsys.com, bhelgaas@google.com,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: move definition of PCI_VENDOR_ID_SYNOPSYS to linux/pci_ids.h
Date: Tue, 17 Feb 2015 15:34:36 +0300	[thread overview]
Message-ID: <54E3355C.40301@cogentembedded.com> (raw)
In-Reply-To: <54E331F2.3010409@cogentembedded.com>

On 2/17/2015 3:20 PM, Sergei Shtylyov wrote:

>> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>

> [...]

>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
>> index e63c02a..38cff8f 100644
>> --- a/include/linux/pci_ids.h
>> +++ b/include/linux/pci_ids.h
>> @@ -2315,6 +2315,8 @@
>>   #define PCI_VENDOR_ID_CENATEK        0x16CA
>>   #define PCI_DEVICE_ID_CENATEK_IDE    0x0001
>>
>> +#define PCI_VENDOR_ID_SYNOPSYS        0x16c3

>     0x16c3 goes before 0x16ca. And the file seems to use uppercase for hex
> numbers...

    Actually no, it's only Cenatek ID that uses upper case, so disregard the 
second comment.

> [...]

WBR, Sergei


      reply	other threads:[~2015-02-17 12:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-17  1:45 [PATCH] usb: move definition of PCI_VENDOR_ID_SYNOPSYS to linux/pci_ids.h Joseph Kogut
2015-02-17  1:57 ` Greg KH
2015-02-17  2:16   ` Joseph Kogut
2015-02-17  2:24     ` Greg KH
2015-02-17 12:20 ` Sergei Shtylyov
2015-02-17 12:34   ` Sergei Shtylyov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54E3355C.40301@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=balbi@ti.com \
    --cc=bhelgaas@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johnyoun@synopsys.com \
    --cc=joseph.kogut@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.