From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 8/9] xen: arm: handle remaining traps from userspace Date: Tue, 17 Feb 2015 15:28:14 +0000 Message-ID: <54E35E0E.1070406@linaro.org> References: <1423542956.5851.9.camel@citrix.com> <1423543523-8010-8-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1423543523-8010-8-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org Cc: tim@xen.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 10/02/15 04:45, Ian Campbell wrote: > case HSR_EC_SMC64: > + BUG_ON(psr_mode_is_32bit(regs->cpsr)); > perfc_incr(trap_smc64); > - inject_undef64_exception(regs, hsr.len); I don't understand why you drop the #undef injection. Is it a mistake? Regards, -- Julien Grall