From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v9 02/13] xen: Add support for VMware cpuid
	leaves
Date: Tue, 17 Feb 2015 15:59:53 +0000
Message-ID: <54E36579.4040705@citrix.com>
References: <1424127915-27004-1-git-send-email-dslutz@verizon.com>
	<1424127915-27004-3-git-send-email-dslutz@verizon.com>
	<54E311BE.7010202@citrix.com>
	<54E373030200007800060B2B@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54E373030200007800060B2B@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Jun Nakajima <jun.nakajima@intel.com>, Tim Deegan <tim@xen.org>, Kevin Tian <kevin.tian@intel.com>, KeirFraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Eddie Dong <eddie.dong@intel.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Don Slutz <dslutz@verizon.com>, xen-devel@lists.xen.org, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>
List-Id: xen-devel@lists.xenproject.org

On 17/02/15 15:57, Jan Beulich wrote:
>>>> On 17.02.15 at 11:02, <andrew.cooper3@citrix.com> wrote:
>> On 16/02/15 23:05, Don Slutz wrote:
>>> --- a/xen/include/asm-x86/hvm/hvm.h
>>> +++ b/xen/include/asm-x86/hvm/hvm.h
>>> @@ -356,6 +356,13 @@ static inline unsigned long hvm_get_shadow_gs_base(struct vcpu *v)
>>>  #define has_viridian_time_ref_count(d) \
>>>      (is_viridian_domain(d) && (viridian_feature_mask(d) & HVMPV_time_ref_count))
>>>  
>>> +#define vmware_feature_mask(d) \
>>> +    (has_hvm_params(d) ? \
>>> +     (d)->arch.hvm_domain.params[HVM_PARAM_VMWARE_HWVER] : 0)
>> I can't spot any use of this vmware_feature_mask().  Is it stale?
> No, it is being used ...
>
>> Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>
>>> +
>>> +#define is_vmware_domain(d) \
>>> +    (is_hvm_domain(d) && vmware_feature_mask(d))
> ... here.
>
> Jan
>

So it is.  I am clearly blind.

~Andrew