Re: [PATCH v2] tools/xenconsoled: Increase file descriptor limit

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 17/02/15 16:48, Wei Liu wrote:
> On Tue, Feb 17, 2015 at 04:37:08PM +0000, Andrew Cooper wrote:
>
>> I am not sure what an admin could usefully do with a logged failure
>> message here.  Xenconsoled will most likely not function in an
>> environment where it is not sufficiently privileged to make this limit
>> adjustment (use of privcmd and /dev/ptmx).
>>
> Does xenconsoled requires CAP_SYS_RESOURCE to make use of privcmd and
> /dev/ptmx? If not, there is a case that your setrlimit fails
> while other parts can still be functional, right?

A slim chance, yes if someone has specifically been playing with
capabilities.

I still don't see how an error message would be useful.  Even if the
call fails, the process still has the default number of file descriptors
and can function fine up until that limit.  If errors were meaningful in
this case, the function wouldn't be void.

~Andrew