Re: [Outreachy kernel] [PATCH] staging: fbtft: fix spacing errors

[Jes Sorensen <jes.sorensen@gmail.com>]

On 02/17/15 14:22, Arnd Bergmann wrote:
> On Tuesday 17 February 2015 14:16:55 Jes Sorensen wrote:
>> On 02/17/15 12:48, Aya Mahfouz wrote:
>>> This patch fixes the following checkpatch.pl errors for
>>> the file fb_bd663474.c:
>>>
>>> ERROR: space prohibited before that close parenthesis ')'
>>> ERROR: space prohibited after that open parenthesis '('
>>> ERROR: space required after that ','
>>>
>>> Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
>>> ---
>>> v1: I know that typically one patch should fix one type of
>>> checkpatch.pl error/warning but given that they are all 
>>> spacing issues, I merged them into one patch.
>>>
>>>  drivers/staging/fbtft/fb_bd663474.c | 100 ++++++++++++++++++------------------
>>>  1 file changed, 50 insertions(+), 50 deletions(-)
>>
>> The patch looks good - your reasoning for merging the patch is sound too
>> since you would otherwise have to modify the same lines 2-3 times.
>>
>> The only issue is that you shouldn't put comments below the
>> signed-off-by line. The comment you added about merging the 3 rounds of
>> changes into one is valid, but I would do that in a cover letter, if you
>> don't feel that is relevant to go into the commit message.
>> Using '--cover-letter' with git format-patch will generate that for you.
> 
> I usually recommend doing it exactly the way that Aya does here
> when there is only one email, but use a cover letter only when
> there are multiple patches in a series to which that comment applies.

I guess this is a question of taste then. I much prefer the cover letter
as it's easier to notice and read, so I always recommend that.

A good example of the rules of Linux aren't always crystal clear :)

Jes