From: Matthew Thode <mthode@mthode.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] colons are invalid characters in netdev names
Date: Tue, 17 Feb 2015 19:33:25 -0600 [thread overview]
Message-ID: <54E3EBE5.5090008@mthode.org> (raw)
In-Reply-To: <20150217192803.21a63afd@uryu.home.lan>
[-- Attachment #1: Type: text/plain, Size: 700 bytes --]
On 02/17/2015 07:28 PM, Stephen Hemminger wrote:
> On Tue, 17 Feb 2015 17:15:42 -0600
> Matthew Thode <mthode@mthode.org> wrote:
>
>> colons are used as a separator in netdev device lookup in dev_ioctl.c
>>
>> Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME
>>
>> Signed-off-by: Matthew Thode <mthode@mthode.org>
>
> What is the exact sequence that causes the problem?
> SIOCSIFNAME already strips of colon.
>
>
It strips the name one access, not creation. You can create a dummy
device and not access it, escaping doesn't seem to help.
ip link add name foo:asdasd type dummy
ip link del dev foo:asdasd # will not be deleted
--
Matthew Thode
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2015-02-18 1:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 23:15 [PATCH] colons are invalid characters in netdev names Matthew Thode
2015-02-17 23:46 ` Lino Sanfilippo
2015-02-17 23:57 ` Matthew Thode
2015-02-18 0:13 ` Lino Sanfilippo
2015-02-18 1:28 ` Stephen Hemminger
2015-02-18 1:33 ` Matthew Thode [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E3EBE5.5090008@mthode.org \
--to=mthode@mthode.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.