From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [OPTIONAL][PATCH v9 13/13] Add xen-hvm-param
Date: Tue, 17 Feb 2015 21:51:50 -0500
Message-ID: <54E3FE46.6000906@terremark.com>
References: <1424127915-27004-1-git-send-email-dslutz@verizon.com>
	<1424127915-27004-14-git-send-email-dslutz@verizon.com>
	<54E34C1A.4040208@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54E34C1A.4040208@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, Don Slutz <dslutz@verizon.com>, xen-devel@lists.xen.org
Cc: Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Jun Nakajima <jun.nakajima@intel.com>, Eddie Dong <eddie.dong@intel.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, George Dunlap <George.Dunlap@eu.citrix.com>, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, Jan Beulich <jbeulich@suse.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
List-Id: xen-devel@lists.xenproject.org

On 02/17/15 09:11, Andrew Cooper wrote:
> On 16/02/15 23:05, Don Slutz wrote:
>> A tool to get and set hvm param.
>>
>> Signed-off-by: Don Slutz <dslutz@verizon.com>
> 
> I had completely forgotten that you did a tool like this before.
> 
> Here is one I implemented myself,
> 
> https://github.com/xenserver/xen-4.5.pg/commit/ec99115818abd1a98f04d5fae2481803ad21db2a
> 
> I was specifically trying to make an extendible tool to avoid the
> currently state of having $N single-purpose tools, and hopefully
> replacing some of the other tools in a more consistent fashion.  e.g.
> xen-hvmcrash will only crash an hvm domain, but could very easily be
> made to do the same to a PV domain (even using the same hypercalls I
> believe, now that some PVH relaxing has occurred).
> 

Having looked at xen-hvmcrash, I am still having questions about when it
would make sense to use.  I would think a pause, dump-core would give a
better info to look at.

> I have half an extension to this tool which will allow you to dump
> various PV rings in the guest, and would like to see about merging
> xen-hvmctx and xenctx together into this tool.
> 

The merging of xen-hvmctx and xenctx is complex.  I do not see that
happening quickly.

> Thoughts?
> 

I combined tool does look good.

These are just the quick thoughts.  May have more later.

   -Don Slutz

> ~Andrew
>