Re: [Xen-devel] [PATCH 13/13] xen: allow more than 512 GB of RAM for 64 bit pv-domains

[Juergen Gross <jgross@suse.com>]

On 02/18/2015 10:49 AM, Jan Beulich wrote:
>>>> On 18.02.15 at 10:37, <JGross@suse.com> wrote:
>> On 02/18/2015 10:21 AM, Paul Bolle wrote:
>>> On Wed, 2015-02-18 at 07:52 +0100, Juergen Gross wrote:
>>>> --- a/arch/x86/xen/Kconfig
>>>> +++ b/arch/x86/xen/Kconfig
>>>> @@ -23,14 +23,29 @@ config XEN_PVHVM
>>>>    	def_bool y
>>>>    	depends on XEN && PCI && X86_LOCAL_APIC
>>>>
>>>> -config XEN_MAX_DOMAIN_MEMORY
>>>> -       int
>>>> -       default 500 if X86_64
>>>> -       default 64 if X86_32
>>>> -       depends on XEN
>>>> -       help
>>>> -         This only affects the sizing of some bss arrays, the unused
>>>> -         portions of which are freed.
>>>> +if X86_64
>>>
>>> Not
>>>       && XEN
>>> ?
>>
>> The complete directory is made only if CONFIG_XEN is set.
>
> But that doesn't mean this file gets used only when XEN is enabled.

Oh, you are right. I seem to have mixed up make and Kconfig of the
directory.

> I would think though that an eventual "if XEN" should have wider
> scope than just this option (i.e. likely almost the entire file).

Indeed.

So either I'll add the XEN dependency for the new option or I do
another patch adding "if XEN" just below configuring XEN and remove
the XEN dependencies in the rest of the entries.

As Luis is just doing a rework of XEN Kconfig stuff, I think I'll add
the XEN dependency.


Juergen