From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/11] ARM: berlin: rework chip and system controller nodes for BG2
Date: Wed, 18 Feb 2015 11:29:50 +0100 [thread overview]
Message-ID: <54E4699E.4010909@gmail.com> (raw)
In-Reply-To: <1423671332-24580-10-git-send-email-antoine.tenart@free-electrons.com>
On 11.02.2015 17:15, Antoine Tenart wrote:
> The chip and system controller nodes are now handled by the Berlin
> controller mfd driver. Its sub-devices are then registered by the mfd
> driver and let the drivers be probed properly, using their own
> sub-nodes.
>
> Rework the device tree to take this changes into account.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
[...]
> - chip: chip-control at ea0000 {
> - compatible = "marvell,berlin2-chip-ctrl";
> - #clock-cells = <1>;
> - #reset-cells = <2>;
> + chip: chip-controller at ea0000 {
> + compatible = "marvell,berlin2-chip-ctrl", "syscon";
> reg = <0xea0000 0x400>;
> + #clock-cells = <1>;
Antoine,
I noticed just now, but we should either have all of clock, reset,
pinctrl as sub-nodes or none. Currently, this has pinctrl and reset
as sub-nodes but clock hooked up to chip-controller.
Sebastian
> clocks = <&refclk>;
> clock-names = "refclk";
>
> - emmc_pmux: emmc-pmux {
> - groups = "G26";
> - function = "emmc";
> + soc_pinctrl: pin-controller {
> + compatible = "marvell,berlin2-soc-pinctrl";
> +
> + emmc_pmux: emmc-pmux {
> + groups = "G26";
> + function = "emmc";
> + };
> + };
> +
> + chip_rst: reset {
> + compatible = "marvell,berlin2-reset";
> + #reset-cells = <2>;
> };
> };
>
> @@ -442,22 +450,26 @@
> };
>
> sysctrl: system-controller at d000 {
> - compatible = "marvell,berlin2-system-ctrl";
> + compatible = "marvell,berlin2-system-ctrl", "syscon";
> reg = <0xd000 0x100>;
>
> - uart0_pmux: uart0-pmux {
> - groups = "GSM4";
> - function = "uart0";
> - };
> + sys_pinctrl: pin-controller {
> + compatible = "marvell,berlin2-system-pinctrl";
>
> - uart1_pmux: uart1-pmux {
> - groups = "GSM5";
> - function = "uart1";
> - };
> + uart0_pmux: uart0-pmux {
> + groups = "GSM4";
> + function = "uart0";
> + };
> +
> + uart1_pmux: uart1-pmux {
> + groups = "GSM5";
> + function = "uart1";
> + };
>
> - uart2_pmux: uart2-pmux {
> - groups = "GSM3";
> - function = "uart2";
> + uart2_pmux: uart2-pmux {
> + groups = "GSM3";
> + function = "uart2";
> + };
> };
> };
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Antoine Tenart <antoine.tenart@free-electrons.com>
Cc: jszhang@marvell.com, zmxu@marvell.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/11] ARM: berlin: rework chip and system controller nodes for BG2
Date: Wed, 18 Feb 2015 11:29:50 +0100 [thread overview]
Message-ID: <54E4699E.4010909@gmail.com> (raw)
In-Reply-To: <1423671332-24580-10-git-send-email-antoine.tenart@free-electrons.com>
On 11.02.2015 17:15, Antoine Tenart wrote:
> The chip and system controller nodes are now handled by the Berlin
> controller mfd driver. Its sub-devices are then registered by the mfd
> driver and let the drivers be probed properly, using their own
> sub-nodes.
>
> Rework the device tree to take this changes into account.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
[...]
> - chip: chip-control@ea0000 {
> - compatible = "marvell,berlin2-chip-ctrl";
> - #clock-cells = <1>;
> - #reset-cells = <2>;
> + chip: chip-controller@ea0000 {
> + compatible = "marvell,berlin2-chip-ctrl", "syscon";
> reg = <0xea0000 0x400>;
> + #clock-cells = <1>;
Antoine,
I noticed just now, but we should either have all of clock, reset,
pinctrl as sub-nodes or none. Currently, this has pinctrl and reset
as sub-nodes but clock hooked up to chip-controller.
Sebastian
> clocks = <&refclk>;
> clock-names = "refclk";
>
> - emmc_pmux: emmc-pmux {
> - groups = "G26";
> - function = "emmc";
> + soc_pinctrl: pin-controller {
> + compatible = "marvell,berlin2-soc-pinctrl";
> +
> + emmc_pmux: emmc-pmux {
> + groups = "G26";
> + function = "emmc";
> + };
> + };
> +
> + chip_rst: reset {
> + compatible = "marvell,berlin2-reset";
> + #reset-cells = <2>;
> };
> };
>
> @@ -442,22 +450,26 @@
> };
>
> sysctrl: system-controller@d000 {
> - compatible = "marvell,berlin2-system-ctrl";
> + compatible = "marvell,berlin2-system-ctrl", "syscon";
> reg = <0xd000 0x100>;
>
> - uart0_pmux: uart0-pmux {
> - groups = "GSM4";
> - function = "uart0";
> - };
> + sys_pinctrl: pin-controller {
> + compatible = "marvell,berlin2-system-pinctrl";
>
> - uart1_pmux: uart1-pmux {
> - groups = "GSM5";
> - function = "uart1";
> - };
> + uart0_pmux: uart0-pmux {
> + groups = "GSM4";
> + function = "uart0";
> + };
> +
> + uart1_pmux: uart1-pmux {
> + groups = "GSM5";
> + function = "uart1";
> + };
>
> - uart2_pmux: uart2-pmux {
> - groups = "GSM3";
> - function = "uart2";
> + uart2_pmux: uart2-pmux {
> + groups = "GSM3";
> + function = "uart2";
> + };
> };
> };
>
>
next prev parent reply other threads:[~2015-02-18 10:29 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 16:15 [PATCH 00/11] ARM: berlin: refactor chip and system controllers Antoine Tenart
2015-02-11 16:15 ` Antoine Tenart
2015-02-11 16:15 ` [PATCH 01/11] mfd: add the Berlin controller driver Antoine Tenart
2015-02-11 16:15 ` Antoine Tenart
2015-02-16 12:48 ` Lee Jones
2015-02-16 12:48 ` Lee Jones
2015-02-17 9:20 ` Antoine Tenart
2015-02-17 9:20 ` Antoine Tenart
2015-02-17 11:54 ` Lee Jones
2015-02-17 11:54 ` Lee Jones
2015-02-18 8:40 ` Antoine Tenart
2015-02-18 8:40 ` Antoine Tenart
2015-02-18 9:09 ` Lee Jones
2015-02-18 9:09 ` Lee Jones
2015-02-18 9:22 ` Antoine Tenart
2015-02-18 9:22 ` Antoine Tenart
2015-02-18 10:40 ` Lee Jones
2015-02-18 10:40 ` Lee Jones
2015-02-18 10:51 ` Antoine Tenart
2015-02-18 10:51 ` Antoine Tenart
2015-02-18 11:10 ` Sebastian Hesselbarth
2015-02-18 11:10 ` Sebastian Hesselbarth
2015-02-18 11:58 ` Lee Jones
2015-02-18 11:58 ` Lee Jones
2015-02-18 13:09 ` Sebastian Hesselbarth
2015-02-18 13:09 ` Sebastian Hesselbarth
2015-02-18 15:06 ` Lee Jones
2015-02-18 15:06 ` Lee Jones
2015-02-18 15:07 ` Lee Jones
2015-02-18 15:07 ` Lee Jones
2015-02-18 15:06 ` Arnd Bergmann
2015-02-18 15:06 ` Arnd Bergmann
2015-02-18 15:59 ` Sebastian Hesselbarth
2015-02-18 15:59 ` Sebastian Hesselbarth
2015-02-18 16:15 ` Arnd Bergmann
2015-02-18 16:15 ` Arnd Bergmann
2015-02-18 16:26 ` Lee Jones
2015-02-18 16:26 ` Lee Jones
2015-02-18 10:27 ` Sebastian Hesselbarth
2015-02-18 10:27 ` Sebastian Hesselbarth
2015-02-11 16:15 ` [PATCH 02/11] Documentation: bindings: add the Berlin controller documentation Antoine Tenart
2015-02-11 16:15 ` Antoine Tenart
2015-02-11 16:15 ` [PATCH 03/11] ARM: berlin: select MFD_BERLIN_CTRL Antoine Tenart
2015-02-11 16:15 ` Antoine Tenart
2015-02-11 16:15 ` [PATCH 04/11] reset: berlin: convert to a platform driver Antoine Tenart
2015-02-11 16:15 ` Antoine Tenart
2015-02-11 16:15 ` [PATCH 05/11] Documentation: bindings: move the Berlin reset documentation Antoine Tenart
2015-02-11 16:15 ` Antoine Tenart
2015-02-11 16:15 ` [PATCH 06/11] pinctrl: berlin: use the regmap provided by syscon Antoine Tenart
2015-02-11 16:15 ` Antoine Tenart
2015-03-05 9:38 ` Linus Walleij
2015-03-05 9:38 ` Linus Walleij
2015-02-11 16:15 ` [PATCH 07/11] pinctrl: berlin: use proper compatibles Antoine Tenart
2015-02-11 16:15 ` Antoine Tenart
2015-03-05 9:39 ` Linus Walleij
2015-03-05 9:39 ` Linus Walleij
2015-02-11 16:15 ` [PATCH 08/11] Documentation: bindings: move the Berlin pinctrl documentation Antoine Tenart
2015-02-11 16:15 ` Antoine Tenart
2015-03-05 9:41 ` Linus Walleij
2015-03-05 9:41 ` Linus Walleij
2015-02-11 16:15 ` [PATCH 09/11] ARM: berlin: rework chip and system controller nodes for BG2 Antoine Tenart
2015-02-11 16:15 ` Antoine Tenart
2015-02-18 10:29 ` Sebastian Hesselbarth [this message]
2015-02-18 10:29 ` Sebastian Hesselbarth
2015-02-18 10:33 ` Antoine Tenart
2015-02-18 10:33 ` Antoine Tenart
2015-02-18 10:35 ` Sebastian Hesselbarth
2015-02-18 10:35 ` Sebastian Hesselbarth
2015-02-11 16:15 ` [PATCH 10/11] ARM: berlin: rework chip and system controller nodes for BG2CD Antoine Tenart
2015-02-11 16:15 ` Antoine Tenart
2015-02-11 16:15 ` [PATCH 11/11] ARM: berlin: rework chip and system controller nodes for BG2Q Antoine Tenart
2015-02-11 16:15 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E4699E.4010909@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.