Re: [Outreachy kernel] [PATCH v3] Staging: i2o: Remove space after the * in a pointer type variable.

[Preeti U Murthy <preeti@linux.vnet.ibm.com>]

Hi Vatika,

On 02/18/2015 04:45 PM, Vatika Harlalka wrote:
> This patch is to remove space after the * in a pointer type variable declaration to follow kernel coding conventions.

You may have noticed that a limit of 80 characters is imposed in the
kernel coding style. It would be good to follow the same in the
changelog as well. So the patch looks is uniformly aligned throughout.
> 
> Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
> ---
> 
>  Changes in v3: Moved changelog below to "---" line.
>  Changes in v2: Changed subject line to make it more descriptive.
> 
>  drivers/staging/i2o/debug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/i2o/debug.c b/drivers/staging/i2o/debug.c
> index 7a16114..4f23e3f 100644
> --- a/drivers/staging/i2o/debug.c
> +++ b/drivers/staging/i2o/debug.c
> @@ -5,7 +5,7 @@
> 
>  static void i2o_report_util_cmd(u8 cmd);
>  static void i2o_report_exec_cmd(u8 cmd);
> -static void i2o_report_fail_status(u8 req_status, u32 * msg);
> +static void i2o_report_fail_status(u8 req_status, u32 *msg);

I see that the definition of this function suffers from the same issue
down below in the file. You may want to correct that as well and club
both the changes in one patch.

>  static void i2o_report_common_status(u8 req_status);
>  static void i2o_report_common_dsc(u16 detailed_status);
> 
Regards
Preeti U Murthy